Error messaging in extension is not very informative to user

VERIFIED FIXED in BW-M6

Status

addons.mozilla.org Graveyard
Collector Extension
VERIFIED FIXED
9 years ago
2 years ago

People

(Reporter: krupa, Assigned: fligtar)

Tracking

unspecified
BW-M6
x86
Mac OS X

Details

(Reporter)

Description

9 years ago
steps to reproduce:
1.Go to Tools->Addons->Extensions
2.Select any add-on
3.Click on Publish->Email address->new email address
4.Enter an email address followed by a comma
5.Click Send email
6.Notice the error message

expected result:
Error message is descriptive/informative to the user

actual result:
Err message-"Error 1400-Invalid parameters" is displayed.

Comment 1

9 years ago
Please make a note here if this requires any new strings or changes.
Assignee: nobody → dave
I have added some more error checking to this dialog so that trailing commas are ignored.

I have also added a user-friendly UI string to replace the technical error above.

r25895

Justin, the new string is in publish.properties

error.invalid_parameters=There was a problem sharing this add-on. Please check that the e-mail address and personal note are valid.
Assignee: dave → fligtar
Status: NEW → ASSIGNED
(Assignee)

Comment 3

9 years ago
Hmm. I was not planning on adding any new strings. I'll think about how to handle this.
(Assignee)

Comment 4

9 years ago
Can we add localization fallback for this new string? By that I mean we check to see if the string exists in the locale, and if not we use english?

I don't want to take any new strings for this release, but since these were added, I think it's the best way to move forward.
(Assignee)

Comment 5

9 years ago
Sorry, instead of English, I meant we should use whatever it was using before.
Ok. Using l10n fallback now.

If the string is available in the bundle, it will display that. If not, it will display the ugly error above.

r25967
(Assignee)

Comment 7

9 years ago
Thanks Dave.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

9 years ago
Trailing commas are now ignored.Also,there is a user friendly message.Will track other user messages as new bugs.Marking this as verified.
Status: RESOLVED → VERIFIED
(Assignee)

Updated

8 years ago
Component: Collections → Collector Extension
QA Contact: collections → collector-extension

Comment 9

6 years ago
I'm still getting an unhelpful message error 1400 when publishing.  Is there another bug related to this?
(In reply to alanjstr from comment #9)
> I'm still getting an unhelpful message error 1400 when publishing.  Is there
> another bug related to this?

The API is no longer maintained and the extension in its current form will be retired soon.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.