493656 - Error messaging in extension is not very informative to user

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.Go to Tools->Addons->Extensions
2.Select any add-on
3.Click on Publish->Email address->new email address
4.Enter an email address followed by a comma
5.Click Send email
6.Notice the error message

expected result:
Error message is descriptive/informative to the user

actual result:
Err message-"Error 1400-Invalid parameters" is displayed.

Comment 1

[Brian King [:kinger]]

Please make a note here if this requires any new strings or changes.

Comment 2

[David McNamara [:mackers]]

I have added some more error checking to this dialog so that trailing commas are ignored.

I have also added a user-friendly UI string to replace the technical error above.

r25895

Justin, the new string is in publish.properties

error.invalid_parameters=There was a problem sharing this add-on. Please check that the e-mail address and personal note are valid.

Comment 3

[Justin Scott [:fligtar]]

Hmm. I was not planning on adding any new strings. I'll think about how to handle this.

Comment 4

[Justin Scott [:fligtar]]

Can we add localization fallback for this new string? By that I mean we check to see if the string exists in the locale, and if not we use english?

I don't want to take any new strings for this release, but since these were added, I think it's the best way to move forward.

Comment 5

[Justin Scott [:fligtar]]

Sorry, instead of English, I meant we should use whatever it was using before.

Comment 6

[David McNamara [:mackers]]

Ok. Using l10n fallback now.

If the string is available in the bundle, it will display that. If not, it will display the ugly error above.

r25967

Comment 7

[Justin Scott [:fligtar]]

Thanks Dave.

Comment 8

[krupa raj[:krupa]]

Trailing commas are now ignored.Also,there is a user friendly message.Will track other user messages as new bugs.Marking this as verified.

Comment 9

[alanjstr]

I'm still getting an unhelpful message error 1400 when publishing.  Is there another bug related to this?

Comment 10

[Brian King [:kinger]]

(In reply to alanjstr from comment #9)
> I'm still getting an unhelpful message error 1400 when publishing.  Is there
> another bug related to this?

The API is no longer maintained and the extension in its current form will be retired soon.