493773 - ignore module.ver for version bumps in release automation

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Robert Kaiser]

Bug 316387 made module.ver get version automatically from version.txt on both trunk and 1.9.1, so we can make release automation forget any logic for bumping version numbers there.

Comment 1

[[e-mail] (:bhearsum)]

This has to get done before we spin 3.5rc1 or else the automation will fall down.

Comment 2

[Robert Kaiser]

The immediate thing that should be done is removing module.ver from the bumpFiles in release_master.py

We have a comment in buildbotcustom's process/factory.py that cites it, that's an easy fix.

Ultimately, in http://hg.mozilla.org/build/tools/file/34afe709615b/release/version-bump.pl#l75 we'll be able to remove all the code that knows how to deal with module.ver.

Overall, this is all pretty easy code removal. Do we run into an error right now if we can't replace a version number? I thought we would just not change it and therefore be relatively safe.

Comment 3

[[e-mail] (:bhearsum)]

(In reply to comment #2)
> The immediate thing that should be done is removing module.ver from the
> bumpFiles in release_master.py
> 
> We have a comment in buildbotcustom's process/factory.py that cites it, that's
> an easy fix.
> 
> Ultimately, in
> http://hg.mozilla.org/build/tools/file/34afe709615b/release/version-bump.pl#l75
> we'll be able to remove all the code that knows how to deal with module.ver.
> 
> Overall, this is all pretty easy code removal. Do we run into an error right
> now if we can't replace a version number? I thought we would just not change it
> and therefore be relatively safe.

Yeah, we do hit an error. fwiw, I was just stating it to make sure it gets done - I think it's totally simple & safe enough to do this late.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: remove module.ver from bumpFiles

Pretty self explanatory, I think.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 378411 [details] [diff] [review]
remove module.ver from bumpFiles

Missed my automation test :-(

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 378411 [details] [diff] [review]
remove module.ver from bumpFiles

changeset:   1150:d1e83fe8fab1

Comment 7

[Robert Kaiser]

Should I file followups for process/factory.py and version-bump.pl changes?

Comment 8

[[e-mail] (:bhearsum)]

If you don't mind filing a follow-up for version-bump.pl that would be great. I don't want to remove support for it until we do a couple releases with the new module.ver, though.

I'll get rid of the comment in factory.py