493955 - Remove module.ver logic from version-bump.pl

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Robert Kaiser]

Now that we don't need to bump versions directly in module.ver any more, we can remove the logic for that from http://hg.mozilla.org/build/tools/file/34afe709615b/release/version-bump.pl#l75 and other places in this file.

Ben says he wants to run through a few releases before that and make sure nothing breaks, though.

Comment 1

[[e-mail] (:bhearsum)]

Going to put this in Future for now.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: untested patch

We're not using the module.ver bits anymore, so should be safe. I'll try it out tomorrow.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 390312 [details] [diff] [review]
untested patch

This is tested and ready for review

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 390312 [details] [diff] [review]
untested patch

We still need this for Firefox 3.0, me thinks.

Comment 5

[Robert Kaiser]

Nick, is Firefox 3.0 running off the hg build tools?

Comment 6

[[e-mail] (:bhearsum)]

Yes, indeed. Back to the future for you, bug 493955.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

KaiRo, version-bump.pl was originally in the Bootstrap framework for Fx3.0 and older releases. We separated it out to reuse it for mercurial-based releases.

Comment 8

[Robert Kaiser]

(In reply to comment #7)
> KaiRo, version-bump.pl was originally in the Bootstrap framework for Fx3.0 and
> older releases. We separated it out to reuse it for mercurial-based releases.

Sure, my point was that if this copy of it isn't used for Fx3.0 (and only a copy in CVS is) then we can safely remove it from this copy and leave it in on the CVS copy. Of course, if the release process for 3.0 also uses the copy from hg then we need to keep it until we EOL that series.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

We split the code out of Bootstrap to prevent duplication, so having separate copies in CVS and hg goes against that. They both use hg.mozilla.org/build/tools.

Comment 10

[Robert Kaiser]

(In reply to comment #9)
> They both use
> hg.mozilla.org/build/tools.

OK, then we need to wait for 1.9.0 EOL before we remove this. Good to know.

Comment 11

[Chris Cooper [:coop] (he/him)]

Mass move of bugs from Release Engineering:Future -> Release Engineering. See
http://coop.deadsquid.com/2010/02/kiss-the-future-goodbye/ for more details.

Comment 12

[Aki Sasaki (not active)]

Comment on attachment 390312 [details] [diff] [review]
untested patch

How about now?

Comment 13

[Aki Sasaki (not active)]

(FF2.0+TB3.0 EOLed)

Comment 14

[Robert Kaiser]

(In reply to comment #13)
> (FF2.0+TB3.0 EOLed)

You mean FF3.0 and TB2.0, actually (as those were the ones named in whiteboard until you removed it in that comment). ;-)

Comment 15

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Unrotted patch

The code changed a bit in (eg bug 500471) so here's the unrotted patch that gets my r+ and landing.

http://hg.mozilla.org/build/tools/rev/204880f4c78c