493893 - Disable "canUndoDeleteOnServer" preference for Gmail IMAP account by default

Status: NEW

(MailNews Core :: Account Manager, enhancement)

Description

[WADA:World Anti-bad-Duping Agency]

Disable "canUndoDeleteOnServer" preference for Gmail IMAP account by default, please.

Although user can use "undelete" if user enables "Advanced IMAP Controls" of Gmail's "Lab" and disables "auto expunge" option of the feature, it's not official feature. To protect users from problem like Bug 417167, please set canUndoDeleteOnServer=false by default as mail.server.serverN.is_gmail=true by default for Gmail IMAP account.

Comment 1

[WADA:World Anti-bad-Duping Agency]

As "Account Wizard for Gmail IMAP" inplemented during Tb 3.0xpre was dropped from Tb 3.0. Enhancement of autoconfig is required.

Comment 2

[:aceman]

Wada, mconley, is this something to be just put into the mailnews/base/ispdata/gmail.rdf file? As it is done in http://mxr.mozilla.org/comm-central/source/mailnews/base/ispdata/aol.rdf#40 . I assume this defaults file is used for new accounts created.

Comment 3

[Ludovic Hirlimann [:Usul]]

(In reply to :aceman from comment #2)
> Wada, mconley, is this something to be just put into the
> mailnews/base/ispdata/gmail.rdf file? As it is done in
> http://mxr.mozilla.org/comm-central/source/mailnews/base/ispdata/aol.rdf#40
> . I assume this defaults file is used for new accounts created.

I think we don't use the rdf file anymore and can't control this kind of settings using the ispdb - so either some autodetect code can be added at the account creation specific for gmail or we should change this to WONTFIX.

Comment 4

[Mark Banner (:standard8)]

Yeah, those ispdata files aren't used any more (apart from movemail), so we'd need to either do this in the backend (or get gmail to make it work!).

Comment 5

[:aceman]

It the mail.server.serverX.is_gmail pref used in any way? I can't find any usage and setting of it. But if there is a place that sets it then the same place could set .canUndoDeleteOnServer.

Comment 6

[:aceman]

Like here:
http://mxr.mozilla.org/comm-central/source/mailnews/imap/src/nsImapIncomingServer.cpp#1190

Comment 7

[Ludovic Hirlimann [:Usul]]

I'm sure Atul knows the answer to this question aceman.

Comment 8

[Atul Jangra [:atuljangra]]

If ispdata files aren't used anymore, then I guess we are left with only one choice of doing this in backend.
I guess we can aim at some places like, http://mxr.mozilla.org/comm-central/source/mailnews/imap/src/nsImapIncomingServer.cpp#2681 , where canUndoDeleteOnServer is by default set to true, we can maybe change this to false in case of GMail servers.

Comment 9

[Atul Jangra [:atuljangra]]

(In reply to Mark Banner (:standard8) from comment #4)
> Yeah, those ispdata files aren't used any more (apart from movemail), so
> we'd need to either do this in the backend (or get gmail to make it work!).

I've not understood the "get gmail to make it work" part, can you elaborate a little? :-)

Cheers!

Comment 10

[:aceman]

Maybe it meant "Politely ask Google to fix their servers ASAP" ? :)

Comment 11

[Atul Jangra [:atuljangra]]

(In reply to :aceman from comment #10)
> Maybe it meant "Politely ask Google to fix their servers ASAP" ? :)

Okay :-) Thanks :-)