493905 - Crash [@ ___TERMINATING_DUE_TO_UNCAUGHT_EXCEPTION___ ] related to bookmarks import

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

We have two reports of this in breakpad today: bp-dda2f2ed-942d-4f1a-9a46-a042a2090519 and bp-0cad5fcd-2d47-4a9e-b6ba-3dfc82090519 (probably the same person).  Nothing terribly useful from the report, but

[11:26pm] hendy: http://www.cocoabuilder.com/archive/message/cocoa/2008/2/6/198164 seems to say that NSXMLDocument will raise an exception and return nil if something (like parsing) goes wrong

Comment 1

[Christopher Henderson]

Attachment: Fix v1.0

Wraps the alloc+init in a try/catch block. Do we need an autorelease there as well?

Comment 2

[Stuart Morgan]

Comment on attachment 378523 [details] [diff] [review]
Fix v1.0

Yep, that is indeed missing an autorelease. sr=smorgan with that added.

Comment 3

[Christopher Henderson]

Attachment: Fix v1.1, for checkin

Autoreleased added.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk.

Comment 5

[chris hofmann]

wonder if this needs to be back ported to firefox 3.0.x to help solve
https://bugzilla.mozilla.org/show_bug.cgi?id=517646#c3 and if other bugs need
to be filed for other problems that have a like crash signature.

Comment 6

[Stuart Morgan]

This is 100% Camino code, so "back ported to firefox" doesn't have any meaning here.

This signature is worthless for grouping crashes; we only have it in the title so it gets associated as one of the relevant bugs in our crashes in Socorro. What you really want in each case is the frame above +[NSException raise:format:], so maybe Socorro should be taught to treat the whole exception chunk as a compound signature.