493922 - convert_i instruction fails in interpreter on 64 bit

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect, P2)

Description

[Lars T Hansen]

This is probably the failure of the interpreter to convert a 32-bit signed integer value to a signed double.

FAILURES:
  abcasm/coverage/C.abc : convert_i long FAILED! expected: -1, actual: 4294967295
  abcasm/coverage/C.abc : convert_i long bis FAILED! expected: -1, actual: 4294967295

Comment 1

[Lars T Hansen]

Attachment: Fix for testconfig.txt to expect these failures on win,lnx x64

Haven't had a chance to test this on Win64 so extra inspection of the regex is appreciated.

Comment 2

[Lars T Hansen]

Attachment: Fix for testconfig.txt to expect these failures on win,lnx x64

New patch includes a bug fix where the name of a test was provided as convert_i but should have been convert_u.

Comment 3

[Tom Harwood]

Comment on attachment 378557 [details] [diff] [review]
Fix for testconfig.txt to expect these failures on win,lnx x64

It's outside the scope of this fix, but these old-school .exception blocks can be supplanted by .try/.catch as we go (the two forms coexist).

Comment 4

[Lars T Hansen]

Attachment: Correct patch - the older patch is part of another bug

Comment 5

[Brent Baker]

Comment on attachment 378642 [details] [diff] [review]
Correct patch - the older patch is part of another bug

but looks like it is also failing on ppc64 mac???

Comment 6

[Lars T Hansen]

Comment on attachment 378642 [details] [diff] [review]
Correct patch - the older patch is part of another bug

redux changeset 1911:9eb7e4c3e15d

Comment 7

[Dan Schaffer]

on 64 bit -Dinterp acceptance runs: (win64,mac-intel64,mac-ppc-64,linux64)
failures:
  abcasm/coverage/B.abc : not uint FAILED! expected: 2147483647, actual: 2147483647
  abcasm/coverage/B.abc : int or uint FAILED! expected: -1, actual: 4294967295
  abcasm/coverage/B.abc : int xor uint FAILED! expected: -1052689, actual: 4293914607
  abcasm/coverage/C.abc : convert_i long FAILED! expected: -1, actual: 4294967295
  abcasm/coverage/C.abc : convert_i long bis FAILED! expected: -1, actual: 4294967295

I will update the smoke tests.

Comment 8

[Dan Schaffer]

previous failures were in Revision: 1911:9eb7e4c3e15d

Comment 9

[Lars T Hansen]

(In reply to comment #7)

Dan, that's bug #493924, I've pushed a change to the testconfig to silence these.

Comment 10

[Steven Johnson]

fixed in changeset:   2006:d5654b2ac8b2