494162 - Classic: Location bar dropdown search row has no styling/background

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

The location bar search row (last row in autocomplete dropdown) is missing styling/background. It has a light grey background in Modern.

The difference is that Classic provides no style rules for .autocomplete-search-box anymore. In SM 1.1 the rules were included in themes/classic/global/<platform>/autocomplete.css after they were moved out of navigator.css as part of bug 329144. At some point in time (Toolkit migration?) those files must have been removed, they are not present anymore on trunk. As a consequence Classic is missing the style rules on all platforms now. :-(

Also see bug 380641 where highlighting was fixed. In comment 17 further discussion on "borders etc." was postponed and then got lost when the bug was closed.

Can someone please shed some light on how to fix this? Is there still a desire/requirement to have platform-specific rules for the search row or can we do it like Modern in navigator.css, possibly using special color names?

Comment 1

[Stefan [:stefanh]]

To be honest, I'm not sure if the old bg color looked nice (on mac). I don't think all platforms should have the same color (border/bg), but I intend to fork navigator.css (style rules should probably be there )in bug 460699 - so you can probably fix this without worrying if it fits on mac.

Instead of putting the rules in navigator.css we could have them in a platform-specific urlbarBindings.css file (since the elemement comes from suite/browser/urlbarBindings.xml), but that's probably an overkill.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Attachment: reintroduce styles for all platforms

(In reply to comment #1)
> you can probably fix this without worrying if it fits on mac.

Before the removal of the respective files, the .autocomplete-search-box styles only differed on Mac:

http://mxr.mozilla.org/mozilla1.8/source/themes/classic/global/unix/autocomplete.css and
http://mxr.mozilla.org/mozilla1.8/source/themes/classic/global/win/autocomplete.css:

.autocomplete-result-popup[nomatch] > .autocomplete-search-box {
  border-top: 1px solid ThreeDHighlight;
}

.autocomplete-search-box {
  border-top: 2px groove -moz-Dialog;
  background-color: -moz-Dialog;
  color: ButtonText;
}

http://mxr.mozilla.org/mozilla1.8/source/themes/classic/global/mac/autocomplete.css:

.autocomplete-result-popup[nomatch] > .autocomplete-search-box {
  border-top: none;
}

.autocomplete-search-box {
  border-top: 1px solid ThreeDDarkShadow;
  background-color: -moz-Dialog;
  color: ButtonText;
}

If we ignore Mac, a simple fix would be to reintroduce the two unix/win rules in Classic's navigator.css (where they are in Modern and have been before bug 329144 which specifially targeted Mac). I attached a patch for that. The Mac part would be bug 460699 then.

Comment 3

[[e-mail]]

Comment on attachment 378920 [details] [diff] [review]
reintroduce styles for all platforms

>+.autocomplete-result-popup
It's not called this any more... also as per Modern it belongs after the other rule.

>+.autocomplete-search-box {
>+  border-top: 2px groove -moz-Dialog;
[Ideally this would use system 3D colours]

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch v2 [Checkin: Comment 7]

(In reply to comment #3)
> (From update of attachment 378920 [details] [diff] [review])
> >+.autocomplete-result-popup
> It's not called this any more... also as per Modern it belongs after the other
> rule.

I should really have checked the Modern version instead of just copying from the old files... Fixed in the new patch.

> >+.autocomplete-search-box {
> >+  border-top: 2px groove -moz-Dialog;
> [Ideally this would use system 3D colours]

I'm not a theme expert and there doesn't seem to be an easy way to find out what ThreeD* resolve to on any given platform and then somehow compare that with -moz-Dialog. I'm open to suggestions; feel free to ask/CC anyone who you think might know better.

Comment 5

[[e-mail]]

Comment on attachment 378985 [details] [diff] [review]
patch v2
[Checkin: Comment 7]

I think there's a "Classic should use system colours" bug that we could note that particular issue under.

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #5)
> (From update of attachment 378985 [details] [diff] [review])
> I think there's a "Classic should use system colours" bug that we could note
> that particular issue under.

Added a comment to bug 360330 (the closest I could find).

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 378985 [details] [diff] [review]
patch v2
[Checkin: Comment 7]


http://hg.mozilla.org/comm-central/rev/6be2790c01cf