380641 - No highlight for "Search Google for" in the location bar

Status: VERIFIED FIXED

(SeaMonkey :: Autocomplete, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070513 SeaMonkey/1.5a] (nightly) (W2Ksp4)

No bug with SeaMonkey.


[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/2007051223 SeaMonkey/1.5a] (suiterunner, tinderbox-builds) (W2Ksp4)

In the location bar, in the history dropdown,
the "Search Google for" item does not highlight when (keyboard) selected.

NB:
*History items do highlight.
*"Search Google for" is otherwise working.

Comment 1

[Stefan [:stefanh]]

fwiw, on mac nothing highlights in the autocomplete history drop-down in Classic. We probably miss a few style rules since we don't use themes/classic/global.

Comment 3

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/2007053102
SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

(Unsurprisingly, bug still there with new Trunk SeaMonkey(/suiterunner).)

Comment 4

[Jürgen 'JiHa' Harter]

I can confirm this for Linux.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a6pre) Gecko/2007061216 Mnenhy/0.7.5.0 SeaMonkey/2.0a1pre

Comment 5

[Stefan [:stefanh]]

Yeah, toolkit doesn't have those style rules.

Comment 6

[Manuel Reimer]

Which rules are missing? Where may I find the relevant part in the old CSS files?

Comment 7

[Stefan [:stefanh]]

The search box is here: http://lxr.mozilla.org/seamonkey/source/suite/browser/urlbarBindings.xml#66

The relevant style rules where in global/platform/autocomplete.css

http://lxr.mozilla.org/seamonkey/source/themes/classic/global/mac/autocomplete.css#93
http://lxr.mozilla.org/seamonkey/source/themes/classic/global/win/autocomplete.css#88
http://lxr.mozilla.org/seamonkey/source/themes/classic/global/unix/autocomplete.css#105

Should be the .autocomplete-search-engine[menuactive="true"] etc rules. You can use "HighlightText" and "Highlight" on mac now as well. I do think you'll need a platform-specific place to put the style rules, though (other stuff might differ).

Comment 8

[Stefan [:stefanh]]

KaiRo told me he thought we should wait doing anything about the autocomplete stuff until we "at least supporting satchel".

Comment 9

[Manuel Reimer]

So this one is blocked by: Bug 304309
Just writing it down here, as I'm unable to enter it, where it should be ;-)

Comment 10

[[e-mail]]

Bug 304309 is not relevant, because this is a Classic-only bug.

You probably only need to move the autocomplete-search-* rules, and if we can use the same rules for mac as winux, even better, because that means we can put them in navigator.css instead of (say) navigator\mac\urlbar.css

It would probably be a good idea to move the Modern styles at the same time.

Comment 11

[Stefan [:stefanh]]

(In reply to comment #10)
> Bug 304309 is not relevant, because this is a Classic-only bug.
> 
> You probably only need to move the autocomplete-search-* rules, and if we can
> use the same rules for mac as winux, even better, because that means we can put
> them in navigator.css instead of (say) navigator\mac\urlbar.css
> 
> It would probably be a good idea to move the Modern styles at the same time.
> 

What about bug 384821 (mac)? There is also bug 378545 (all) and bug 379192.

Comment 12

[[e-mail]]

(In reply to comment #11)
>What about bug 384821 (mac)? There is also bug 378545 (all) and bug 379192.
I don't think bug 304309 will affect any of these, especially not bug 379192.

Comment 13

[Stefan [:stefanh]]

Re the autocomplete-search-* rules: I actually removed those from navigator.css in bug 329144 ;-) See https://bugzilla.mozilla.org/show_bug.cgi?id=329144#c16 (but as I said, Highlight and HighlightText works now).

Comment 14

[[e-mail]]

(In reply to comment #13)
>Re the autocomplete-search-* rules: I actually removed those from navigator.css
>in bug 329144 ;-) See https://bugzilla.mozilla.org/show_bug.cgi?id=329144#c16
>(but as I said, Highlight and HighlightText works now).
But not on branch, so that patch was at least still necessary there, right?
So will backing that patch out on trunk fix this bug?

Comment 15

[Stefan [:stefanh]]

(In reply to comment #14)
> (In reply to comment #13)
> >Re the autocomplete-search-* rules: I actually removed those from navigator.css
> >in bug 329144 ;-) See https://bugzilla.mozilla.org/show_bug.cgi?id=329144#c16
> >(but as I said, Highlight and HighlightText works now).
> But not on branch, so that patch was at least still necessary there, right?
> So will backing that patch out on trunk fix this bug?
> 

Just adding the highlight rules will fix this bug. But we still have to fix the border styles, I think. If you look at the patch you'll see that I moved some other rules as well.

Comment 16

[Stefan [:stefanh]]

Attachment: common style rules

I guess we could go with this one. On mac there's no need for border rules, but I miss this one (from classic/global/mac/autocomplete.css):

.autocomplete-result-popup[nomatch] > .autocomplete-search-box {
  border-top: none;
}

Not sure how this will look on win/nix, though... Maybe someone could try? Neil, since there are more styles rules concerning the autocomplete widget that has to be added somewhere, can we have a platform-specific file that deals with all the stuff that has to be different (I'm thinking of the other bugs that most likely will need some platform-tweaks).

Comment 17

[Stefan [:stefanh]]

Attachment: Only fix highlight issue

I propose that we just fix the highlight issue - we can have a further discussion on what to do with the borders etc.

Comment 18

[Stefan [:stefanh]]

Checking in themes/classic/navigator/navigator.css;
/cvsroot/mozilla/themes/classic/navigator/navigator.css,v  <--  navigator.css
new revision: 1.36; previous revision: 1.35
done

Comment 19

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a7pre) Gecko/200707030505 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

V.Fixed, as reporter.