494307 - Make comm-central locale Makefiles work with generic L10n repack factories

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Robert Kaiser]

For making sure we're using the correct Mozilla revision with L10n builds in new L10n buildbot factories, we should add an ident-mozilla target in addition to the ident target in our locales Makefiles.

Additionally, we should make ident and upload-l10n-% actually work by using the correct MOZILLA_SRCDIR var instead of the non-existing MOZ_SRCDIR (ouch for adding it like that at all).

Comment 1

[Robert Kaiser]

Attachment: add new target and fix the others

From what I see, this patch should be all needed in the build to get new-style L10n repack to work, the rest of the infrastructure is already there.

Comment 2

[Robert Kaiser]

Attachment: Print all revisions from ident instead

Pike told me he solved this differently for Fennec, and we probably should follow that model. Therefore, print both revisions from ident itself.

Comment 3

[Robert Kaiser]

Attachment: also sync SeaMonkey run_for_effects with other apps

OK, because it's so much fun, here's one more change, bringing SeaMonkey's run_for_effects into sync with all the others, so that we generate a branding dir which is needed for Mac unpack to succeed.

Also shifting review to dmose as Mark is on vacation.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 379131 [details] [diff] [review]
also sync SeaMonkey run_for_effects with other apps

r=me on the ident and run_for_effects changes.

The MOZILLA_SRCDIR stuff is out of my league, though the name itself sounds familiar from other comm-central patches.

Comment 5

[Philippe M. Chiasson (:gozer)]

Comment on attachment 379131 [details] [diff] [review]
also sync SeaMonkey run_for_effects with other apps

Looks good (and tested) for ident and MOZILLA_SRCDIR changes.

Not sure what the run_for_effects change is about, so I am not testing/reviewing it.

Comment 6

[Philippe M. Chiasson (:gozer)]

Having looked at http://hg.mozilla.org/releases/mozilla-1.9.1/annotate/40faadef447e/browser/locales/Makefile.in#l67, I can see that the run_for_effects change should probably always have been in suite/locale/Makefile.in.

I just tested it as well, so that's r=gozer

Comment 7

[Robert Kaiser]

Comment on attachment 379131 [details] [diff] [review]
also sync SeaMonkey run_for_effects with other apps

dmose forwarded his review to gozer on IRC, and the patch should now be covered.

Comment 8

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/7a7b0f0a19b6