Make comm-central locale Makefiles work with generic L10n repack factories

RESOLVED FIXED in Thunderbird 3.0b3

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: kairo, Assigned: kairo)

Tracking

Trunk
Thunderbird 3.0b3
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

9 years ago
For making sure we're using the correct Mozilla revision with L10n builds in new L10n buildbot factories, we should add an ident-mozilla target in addition to the ident target in our locales Makefiles.

Additionally, we should make ident and upload-l10n-% actually work by using the correct MOZILLA_SRCDIR var instead of the non-existing MOZ_SRCDIR (ouch for adding it like that at all).
(Assignee)

Comment 1

9 years ago
Created attachment 379000 [details] [diff] [review]
add new target and fix the others

From what I see, this patch should be all needed in the build to get new-style L10n repack to work, the rest of the infrastructure is already there.
Attachment #379000 - Flags: review?(bugzilla)
(Assignee)

Comment 2

9 years ago
Created attachment 379129 [details] [diff] [review]
Print all revisions from ident instead

Pike told me he solved this differently for Fennec, and we probably should follow that model. Therefore, print both revisions from ident itself.
Attachment #379000 - Attachment is obsolete: true
Attachment #379129 - Flags: review?(bugzilla)
Attachment #379000 - Flags: review?(bugzilla)
(Assignee)

Comment 3

9 years ago
Created attachment 379131 [details] [diff] [review]
also sync SeaMonkey run_for_effects with other apps

OK, because it's so much fun, here's one more change, bringing SeaMonkey's run_for_effects into sync with all the others, so that we generate a branding dir which is needed for Mac unpack to succeed.

Also shifting review to dmose as Mark is on vacation.
Attachment #379129 - Attachment is obsolete: true
Attachment #379131 - Flags: review?
Attachment #379129 - Flags: review?(bugzilla)
(Assignee)

Updated

9 years ago
Summary: Add ident-mozilla target and use correct vars in ident and l10n-upload → Make comm-central locale Makefiles work with generic L10n repack factories
(Assignee)

Updated

9 years ago
Attachment #379131 - Flags: review? → review?(dmose)

Comment 4

9 years ago
Comment on attachment 379131 [details] [diff] [review]
also sync SeaMonkey run_for_effects with other apps

r=me on the ident and run_for_effects changes.

The MOZILLA_SRCDIR stuff is out of my league, though the name itself sounds familiar from other comm-central patches.
Attachment #379131 - Flags: review+
Comment on attachment 379131 [details] [diff] [review]
also sync SeaMonkey run_for_effects with other apps

Looks good (and tested) for ident and MOZILLA_SRCDIR changes.

Not sure what the run_for_effects change is about, so I am not testing/reviewing it.
Attachment #379131 - Flags: review+
Having looked at http://hg.mozilla.org/releases/mozilla-1.9.1/annotate/40faadef447e/browser/locales/Makefile.in#l67, I can see that the run_for_effects change should probably always have been in suite/locale/Makefile.in.

I just tested it as well, so that's r=gozer
(Assignee)

Comment 7

9 years ago
Comment on attachment 379131 [details] [diff] [review]
also sync SeaMonkey run_for_effects with other apps

dmose forwarded his review to gozer on IRC, and the patch should now be covered.
Attachment #379131 - Flags: review?(dmose)
(Assignee)

Comment 8

9 years ago
Pushed as http://hg.mozilla.org/comm-central/rev/7a7b0f0a19b6
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Depends on: 494576
Depends on: 496196
Flags: in-testsuite-
Target Milestone: --- → Thunderbird 3.0b3
No longer blocks: 547518
You need to log in before you can comment on or make changes to this bug.