494311 - Remove the locale from updater.ini

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Robert Strong (they/them - no direct email)]

With Bug 488936 fixed the locale can be removed from the updater.ini though it isn't harming anything by it being there.

Comment 1

[Mark Banner (:standard8) (afk until 8th Aug)]

Robert, do you mean remove updater.ini from the locale? There is no locale in updater.ini afaict:

http://mxr.mozilla.org/comm-central/source/mail/locales/en-US/updater/updater.ini

Comment 2

[Robert Strong (they/them - no direct email)]

Sorry for not being clearer. The updater_append.ini in the locales dir gets concatenated to the updater.ini. This updater_append.ini can be removed and the Makefile modified accordingly as done in Bug 488936 for Firefox
http://mxr.mozilla.org/comm-central/source/mail/locales/updater_append.ini
http://mxr.mozilla.org/comm-central/source/mail/locales/Makefile.in#277

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev2 - forgot to remove sed -e "s/%AB_CD%/$(AB_CD)/"

Comment 5

[Robert Strong (they/them - no direct email)]

btw: I'm going to be gone until the 28th so please feel free to land this if you want to.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 379250 [details] [diff] [review]
patch rev2 - forgot to remove sed -e "s/%AB_CD%/$(AB_CD)/"

Asking Phil for review in case he wants to take this off of Mark's plate

Comment 7

[Phil Ringnalda (:philor)]

Comment on attachment 379250 [details] [diff] [review]
patch rev2 - forgot to remove sed -e "s/%AB_CD%/$(AB_CD)/"

Yup.

Comment 8

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/ac372b721b16