Closed Bug 494311 Opened 12 years ago Closed 12 years ago

Remove the locale from updater.ini

Categories

(Thunderbird :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file, 1 obsolete file)

With Bug 488936 fixed the locale can be removed from the updater.ini though it isn't harming anything by it being there.
Robert, do you mean remove updater.ini from the locale? There is no locale in updater.ini afaict:

http://mxr.mozilla.org/comm-central/source/mail/locales/en-US/updater/updater.ini
Sorry for not being clearer. The updater_append.ini in the locales dir gets concatenated to the updater.ini. This updater_append.ini can be removed and the Makefile modified accordingly as done in Bug 488936 for Firefox
http://mxr.mozilla.org/comm-central/source/mail/locales/updater_append.ini
http://mxr.mozilla.org/comm-central/source/mail/locales/Makefile.in#277
Attached patch patch rev1 (obsolete) — Splinter Review
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #379213 - Flags: review?(bugzilla)
Attachment #379213 - Attachment is obsolete: true
Attachment #379250 - Flags: review?(bugzilla)
Attachment #379213 - Flags: review?(bugzilla)
btw: I'm going to be gone until the 28th so please feel free to land this if you want to.
Attachment #379250 - Flags: review?(philringnalda)
Comment on attachment 379250 [details] [diff] [review]
patch rev2 - forgot to remove sed -e "s/%AB_CD%/$(AB_CD)/"

Asking Phil for review in case he wants to take this off of Mark's plate
Attachment #379250 - Flags: review?(philringnalda)
Attachment #379250 - Flags: review?(bugzilla)
Attachment #379250 - Flags: review+
Comment on attachment 379250 [details] [diff] [review]
patch rev2 - forgot to remove sed -e "s/%AB_CD%/$(AB_CD)/"

Yup.
http://hg.mozilla.org/comm-central/rev/ac372b721b16
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.