494328 - Media file display names should use decodeURIComponent instead of decodeURI

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Geoff Lankow (:darktrojan)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4

Just nitpicking really, since we're only displaying the filename of the media file, there are no special characters to watch out for.

Reproducible: Always

Steps to Reproduce:
Open a podcast feed with files named like "Episode #4", this will be encoded in the XML as "Episode%20%234"
Actual Results:  
Will display as "Episode %234"

Expected Results:  
Should display as "Episode #4"

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Really simple patch

Comment 2

[Tanner M. Young [:tmyoung]]

Comment on attachment 379033 [details] [diff] [review]
Really simple patch

Requested review from sayrer.

Comment 3

[Tanner M. Young [:tmyoung]]

Attachment: Testcase

This is a simple testcase.

Comment 4

[Tanner M. Young [:tmyoung]]

Attachment: Testcase

This is the actual testcase.

Comment 5

[Tanner M. Young [:tmyoung]]

We're waiting on an automated testcase to land this.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: patch

Comment 7

[Tanner M. Young [:tmyoung]]

Geoff: Do you have check-in privileges?

Comment 8

[Geoff Lankow (:darktrojan)]

(In reply to comment #7)
> Geoff: Do you have check-in privileges?

No.

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This requires approval to land now.

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/3b43d69a70f0