Media file display names should use decodeURIComponent instead of decodeURI

RESOLVED FIXED in Firefox 4.0b3

Status

()

--
trivial
RESOLVED FIXED
10 years ago
8 years ago

People

(Reporter: darktrojan, Assigned: darktrojan)

Tracking

Trunk
Firefox 4.0b3
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4

Just nitpicking really, since we're only displaying the filename of the media file, there are no special characters to watch out for.

Reproducible: Always

Steps to Reproduce:
Open a podcast feed with files named like "Episode #4", this will be encoded in the XML as "Episode%20%234"
Actual Results:  
Will display as "Episode %234"

Expected Results:  
Should display as "Episode #4"
(Assignee)

Comment 1

10 years ago
Created attachment 379033 [details] [diff] [review]
Really simple patch
Attachment #379033 - Flags: review?
Attachment #379033 - Flags: review? → review?(sayrer)
Comment on attachment 379033 [details] [diff] [review]
Really simple patch

Requested review from sayrer.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Created attachment 437042 [details]
Testcase

This is a simple testcase.
Created attachment 437043 [details]
Testcase

This is the actual testcase.
Attachment #437042 - Attachment is obsolete: true
We're waiting on an automated testcase to land this.
Flags: in-testsuite?
(Assignee)

Comment 6

9 years ago
Created attachment 450612 [details] [diff] [review]
patch
Assignee: nobody → geoff
Attachment #379033 - Attachment is obsolete: true
Attachment #437043 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #450612 - Flags: review?(sayrer)
Attachment #379033 - Flags: review?(sayrer)
Version: unspecified → Trunk
Attachment #450612 - Flags: review?(sayrer) → review?(mano)

Updated

8 years ago
Attachment #450612 - Flags: review?(mano) → review+
Geoff: Do you have check-in privileges?
(Assignee)

Comment 8

8 years ago
(In reply to comment #7)
> Geoff: Do you have check-in privileges?

No.
Keywords: checkin-needed
This requires approval to land now.
Keywords: checkin-needed
Attachment #450612 - Flags: approval2.0?

Updated

8 years ago
Attachment #450612 - Flags: approval2.0? → approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/3b43d69a70f0
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite? → in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b3
You need to log in before you can comment on or make changes to this bug.