Closed
Bug 494328
Opened 14 years ago
Closed 13 years ago
Media file display names should use decodeURIComponent instead of decodeURI
Categories
(Firefox Graveyard :: RSS Discovery and Preview, defect)
Firefox Graveyard
RSS Discovery and Preview
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 4.0b3
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
Attachments
(1 file, 3 obsolete files)
4.12 KB,
patch
|
sayrer
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4 Just nitpicking really, since we're only displaying the filename of the media file, there are no special characters to watch out for. Reproducible: Always Steps to Reproduce: Open a podcast feed with files named like "Episode #4", this will be encoded in the XML as "Episode%20%234" Actual Results: Will display as "Episode %234" Expected Results: Should display as "Episode #4"
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #379033 -
Flags: review?
Updated•14 years ago
|
Attachment #379033 -
Flags: review? → review?(sayrer)
Comment 2•14 years ago
|
||
Comment on attachment 379033 [details] [diff] [review] Really simple patch Requested review from sayrer.
Updated•14 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 3•13 years ago
|
||
This is a simple testcase.
Comment 4•13 years ago
|
||
This is the actual testcase.
Attachment #437042 -
Attachment is obsolete: true
Assignee | ||
Comment 6•13 years ago
|
||
Assignee: nobody → geoff
Attachment #379033 -
Attachment is obsolete: true
Attachment #437043 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #450612 -
Flags: review?(sayrer)
Attachment #379033 -
Flags: review?(sayrer)
Updated•13 years ago
|
Version: unspecified → Trunk
Updated•13 years ago
|
Attachment #450612 -
Flags: review?(sayrer) → review?(mano)
Updated•13 years ago
|
Attachment #450612 -
Flags: review?(mano) → review+
Comment 7•13 years ago
|
||
Geoff: Do you have check-in privileges?
Assignee | ||
Comment 8•13 years ago
|
||
(In reply to comment #7) > Geoff: Do you have check-in privileges? No.
Keywords: checkin-needed
This requires approval to land now.
Keywords: checkin-needed
Updated•13 years ago
|
Attachment #450612 -
Flags: approval2.0?
Updated•13 years ago
|
Attachment #450612 -
Flags: approval2.0? → approval2.0+
Updated•13 years ago
|
Keywords: checkin-needed
Comment 10•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3b43d69a70f0
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite? → in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b3
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•