Closed Bug 494328 Opened 14 years ago Closed 13 years ago

Media file display names should use decodeURIComponent instead of decodeURI

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 4.0b3

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file, 3 obsolete files)

patch
4.12 KB, patch
sayrer
: review+
benjamin
: approval2.0+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4

Just nitpicking really, since we're only displaying the filename of the media file, there are no special characters to watch out for.

Reproducible: Always

Steps to Reproduce:
Open a podcast feed with files named like "Episode #4", this will be encoded in the XML as "Episode%20%234"
Actual Results:  
Will display as "Episode %234"

Expected Results:  
Should display as "Episode #4"
Attached patch Really simple patch (obsolete) — — Splinter Review 

        Attachment #379033 -
        Flags: review?

        Attachment #379033 -
        Flags: review? → review?(sayrer)

    
    

    
  
Comment on attachment 379033 [details] [diff] [review]
Really simple patch

Requested review from sayrer.
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
    

    
  

      
      
      
      

        Attached file
          
        Testcase (obsolete)
        — 
      

    


  
This is a simple testcase.

    
    

    
  

      
      
      
      

        Attached file
          
        Testcase (obsolete)
        — 
      

    


  
This is the actual testcase.

        Attachment #437042 -
        Attachment is obsolete: true

    
    

    
  
We're waiting on an automated testcase to land this.
Flags: in-testsuite?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  
Assignee: nobody → geoff

        Attachment #379033 -
        Attachment is obsolete: true

        Attachment #437043 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #450612 -
        Flags: review?(sayrer)

        Attachment #379033 -
        Flags: review?(sayrer)
Version: unspecified → Trunk

        Attachment #450612 -
        Flags: review?(sayrer) → review?(mano)

    
  

        Attachment #450612 -
        Flags: review?(mano) → review+

    
    

    
  
Geoff: Do you have check-in privileges?

    
    

    
  
(In reply to comment #7)
> Geoff: Do you have check-in privileges?

No.
Keywords: checkin-needed

    
    

    
  
This requires approval to land now.
Keywords: checkin-needed

        Attachment #450612 -
        Flags: approval2.0?

    
  

        Attachment #450612 -
        Flags: approval2.0? → approval2.0+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/3b43d69a70f0
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite? → in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b3

    
  
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.