494397 - SimpleTest.js |window.onerror| calls |SimpleTest.finish()| while test is still running

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090518 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/a7c0b3588242
 +http://hg.mozilla.org/comm-central/rev/6786ebf24275 + bug 493008 patches)

I found this (instead) while trying to reproduce bug 492956 (with this few days old build).

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: Initial log

Note that UI reports 1+3 errors and log summary confirms this with 'Failed: 4';
yet, log itself contains 1+1 errors only :-(

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 379151 [details]
Initial log


Not this bug, but while here:

> [...] Error thrown during test: this.Utils is undefined - got 0, expected 1

The Error Console reports the full error:
{
Error: this.Utils is undefined
Source File: chrome://global/content/bindings/videocontrols.xml
Line: 274
}

I wonder if it would be possible to retrieve the file+line data?
Maybe bug 481406 will do that (too)?

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: Fixed log

Now the UI, the detail and the summary agree: 1+0 error.

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Tabs cleanup, Improve+Add error messages, Use executeSoon() [Checkin: Comment 7 & 8]

Comment 5

[Serge Gautherie (:sgautherie)]

Ping for review.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 379166 [details] [diff] [review]
(Av1) Tabs cleanup, Improve+Add error messages, Use executeSoon()
[Checkin: Comment 7 & 8]

ok(true, "wfm").

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 379166 [details] [diff] [review]
(Av1) Tabs cleanup, Improve+Add error messages, Use executeSoon()
[Checkin: Comment 7 & 8]


http://hg.mozilla.org/mozilla-central/rev/26bfd1ee3185

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 379166 [details] [diff] [review]
(Av1) Tabs cleanup, Improve+Add error messages, Use executeSoon()
[Checkin: Comment 7 & 8]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6c64b67339e1

Comment 9

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) Use 'diag' parameter for exceptions

A nit I noticed afterward.

Comment 10

[Rob Campbell [:rc] (:robcee)]

what does the output from this look like? Is the event going to be wedged into the string with no spacing?

Comment 11

[Serge Gautherie (:sgautherie)]

Attachment: (Bv2) Update interactive report, Use 'diag' parameter from |window.onerror| [Checkin: Comment 14 & 15 & 16]

Bv1, with comment 10 suggestion(s):
Make interactive report more like file report.

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 386919 [details] [diff] [review]
(Bv2) Update interactive report, Use 'diag' parameter from |window.onerror|
[Checkin: Comment 14 & 15 & 16]


rcampbell: ping for review?

Comment 13

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 386919 [details] [diff] [review]
(Bv2) Update interactive report, Use 'diag' parameter from |window.onerror|
[Checkin: Comment 14 & 15 & 16]

ok

Comment 14

[Serge Gautherie (:sgautherie)]

Comment on attachment 386919 [details] [diff] [review]
(Bv2) Update interactive report, Use 'diag' parameter from |window.onerror|
[Checkin: Comment 14 & 15 & 16]


http://hg.mozilla.org/mozilla-central/rev/5d7e05797de0

Comment 15

[Serge Gautherie (:sgautherie)]

Comment on attachment 386919 [details] [diff] [review]
(Bv2) Update interactive report, Use 'diag' parameter from |window.onerror|
[Checkin: Comment 14 & 15 & 16]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/2ddcf171ca75

Comment 16

[Serge Gautherie (:sgautherie)]

Comment on attachment 386919 [details] [diff] [review]
(Bv2) Update interactive report, Use 'diag' parameter from |window.onerror|
[Checkin: Comment 14 & 15 & 16]


http://hg.mozilla.org/releases/mozilla-1.9.2/rev/3403e00f4b3c

Comment 17

[Serge Gautherie (:sgautherie)]

Moving 'crash' keyword from bug 492956.