Closed Bug 494397 Opened 12 years ago Closed 12 years ago

SimpleTest.js |window.onerror| calls |SimpleTest.finish()| while test is still running

Categories

(Testing :: Mochitest, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(Blocks 1 open bug, )

Details

(Keywords: autotest-issue, crash, fixed1.9.1, Whiteboard: [Av1: fixed1.9.1rc3; Bv2: fixed1.9.2b1 fixed1.9.1.4])

Attachments

(4 files, 1 obsolete file)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090518 SeaMonkey/2.0b1pre] (experimental/_m-c_, home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/a7c0b3588242
 +http://hg.mozilla.org/comm-central/rev/6786ebf24275 + bug 493008 patches)

I found this (instead) while trying to reproduce bug 492956 (with this few days old build).
Attached file Initial log
Note that UI reports 1+3 errors and log summary confirms this with 'Failed: 4';
yet, log itself contains 1+1 errors only :-(
Comment on attachment 379151 [details]
Initial log


Not this bug, but while here:

> [...] Error thrown during test: this.Utils is undefined - got 0, expected 1

The Error Console reports the full error:
{
Error: this.Utils is undefined
Source File: chrome://global/content/bindings/videocontrols.xml
Line: 274
}

I wonder if it would be possible to retrieve the file+line data?
Maybe bug 481406 will do that (too)?
Depends on: 481406
Depends on: 365929
Attached file Fixed log
Now the UI, the detail and the summary agree: 1+0 error.
Blocks: 492956
Blocks: 451287
No longer blocks: 483407
Blocks: 365929
No longer depends on: 365929
Attachment #379166 - Flags: review?(jwalden+bmo)
Ping for review.
Attachment #379166 - Flags: review?(rcampbell) → review+
Comment on attachment 379166 [details] [diff] [review]
(Av1) Tabs cleanup, Improve+Add error messages, Use executeSoon()
[Checkin: Comment 7 & 8]

ok(true, "wfm").
Comment on attachment 379166 [details] [diff] [review]
(Av1) Tabs cleanup, Improve+Add error messages, Use executeSoon()
[Checkin: Comment 7 & 8]


http://hg.mozilla.org/mozilla-central/rev/26bfd1ee3185
Attachment #379166 - Attachment description: (Av1) Tabs cleanup, Improve+Add error messages, Use executeSoon() → (Av1) Tabs cleanup, Improve+Add error messages, Use executeSoon() [Checkin: Comment 7]
Attachment #379166 - Flags: review?(jwalden+bmo)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Attachment #379166 - Attachment description: (Av1) Tabs cleanup, Improve+Add error messages, Use executeSoon() [Checkin: Comment 7] → (Av1) Tabs cleanup, Improve+Add error messages, Use executeSoon() [Checkin: Comment 7 & 8]
Comment on attachment 379166 [details] [diff] [review]
(Av1) Tabs cleanup, Improve+Add error messages, Use executeSoon()
[Checkin: Comment 7 & 8]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6c64b67339e1
Keywords: fixed1.9.1
Whiteboard: [fixed1.9.1rc2+]
A nit I noticed afterward.
Attachment #384296 - Flags: review?(rcampbell)
Whiteboard: [fixed1.9.1rc2+] → [fixed1.9.1rc3]
what does the output from this look like? Is the event going to be wedged into the string with no spacing?
Bv1, with comment 10 suggestion(s):
Make interactive report more like file report.
Attachment #384296 - Attachment is obsolete: true
Attachment #386919 - Flags: review?(rcampbell)
Attachment #384296 - Flags: review?(rcampbell)
Depends on: 502603
No longer depends on: 481406
Blocks: 511888
Comment on attachment 386919 [details] [diff] [review]
(Bv2) Update interactive report, Use 'diag' parameter from |window.onerror|
[Checkin: Comment 14 & 15 & 16]


rcampbell: ping for review?
Attachment #386919 - Flags: review?(rcampbell) → review+
Comment on attachment 386919 [details] [diff] [review]
(Bv2) Update interactive report, Use 'diag' parameter from |window.onerror|
[Checkin: Comment 14 & 15 & 16]

ok
Comment on attachment 386919 [details] [diff] [review]
(Bv2) Update interactive report, Use 'diag' parameter from |window.onerror|
[Checkin: Comment 14 & 15 & 16]


http://hg.mozilla.org/mozilla-central/rev/5d7e05797de0
Attachment #386919 - Attachment description: (Bv2) Update interactive report, Use 'diag' parameter from |window.onerror| → (Bv2) Update interactive report, Use 'diag' parameter from |window.onerror| [Checkin: Comment 14]
Keywords: checkin-needed
Whiteboard: [fixed1.9.1rc3] → [c-n: Bv2 to m-1.9.2] [fixed1.9.1rc3: Av1]
Target Milestone: mozilla1.9.2a1 → mozilla1.9.3a1
Comment on attachment 386919 [details] [diff] [review]
(Bv2) Update interactive report, Use 'diag' parameter from |window.onerror|
[Checkin: Comment 14 & 15 & 16]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/2ddcf171ca75
Attachment #386919 - Attachment description: (Bv2) Update interactive report, Use 'diag' parameter from |window.onerror| [Checkin: Comment 14] → (Bv2) Update interactive report, Use 'diag' parameter from |window.onerror| [Checkin: Comment 14 & 15]
Whiteboard: [c-n: Bv2 to m-1.9.2] [fixed1.9.1rc3: Av1] → [c-n: Bv2 to m-1.9.2] [fixed1.9.1rc3: Av1; fixed1.9.1.3: Bv2]
Whiteboard: [c-n: Bv2 to m-1.9.2] [fixed1.9.1rc3: Av1; fixed1.9.1.3: Bv2] → [c-n: Bv2 to m-1.9.2] [fixed1.9.1rc3: Av1; fixed1.9.1.4: Bv2]
Depends on: 514667
Comment on attachment 386919 [details] [diff] [review]
(Bv2) Update interactive report, Use 'diag' parameter from |window.onerror|
[Checkin: Comment 14 & 15 & 16]


http://hg.mozilla.org/releases/mozilla-1.9.2/rev/3403e00f4b3c
Attachment #386919 - Attachment description: (Bv2) Update interactive report, Use 'diag' parameter from |window.onerror| [Checkin: Comment 14 & 15] → (Bv2) Update interactive report, Use 'diag' parameter from |window.onerror| [Checkin: Comment 14 & 15 & 16]
Keywords: checkin-needed
Whiteboard: [c-n: Bv2 to m-1.9.2] [fixed1.9.1rc3: Av1; fixed1.9.1.4: Bv2] → [Av1: fixed1.9.1rc3; Bv2: fixed1.9.2b1 fixed1.9.1.3]
Whiteboard: [Av1: fixed1.9.1rc3; Bv2: fixed1.9.2b1 fixed1.9.1.3] → [Av1: fixed1.9.1rc3; Bv2: fixed1.9.2b1 fixed1.9.1.4]
Moving 'crash' keyword from bug 492956.
Keywords: crash
Blocks: 482261
Blocks: 615546
You need to log in before you can comment on or make changes to this bug.