Closed Bug 494421 Opened 11 years ago Closed 7 years ago

Use Google as network geolocation provider

Categories

(SeaMonkey :: Project Organization, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: kairo, Assigned: Callek)

References

Details

Attachments

(1 file, 1 obsolete file)

The network geolocation provider integrated in SeaMonkey for bug 488472 will land without accessing an actual source for the gelocation info, as we still need to get permission from Google to use their service as Firefox does it.

The information I have from them is that they want to set up a general policy for using this service and granted MoCo/Firefox a special exception to use it even before such a policy is out there - they don't feel it's a good idea to expand the list of special permission further though and rather want us to hop on with the general policy once they have it.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
This is the patch, requesting reviews to sign it off from a code POV, I'll stay in contact with Google to get sign-off from the provider side.
Attachment #379253 - Flags: superreview?(neil)
Attachment #379253 - Flags: review?(neil)
Attachment #379253 - Flags: superreview?(neil)
Attachment #379253 - Flags: superreview+
Attachment #379253 - Flags: review?(neil)
Attachment #379253 - Flags: review+
Bug 677256 Has implemented a new variant of the Google Location Service API for Gecko 9 and up, here a patch to use that if it may ever get allowed.
Attachment #379253 - Attachment is obsolete: true
Attachment #554426 - Flags: superreview?(neil)
Attachment #554426 - Flags: review+
Attachment #554426 - Flags: superreview?(neil) → superreview+
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #2)
> Created attachment 554426 [details] [diff] [review]
> v2: set Google geolocation provider v2 by default
> 
> Bug 677256 Has implemented a new variant of the Google Location Service API
> for Gecko 9 and up, here a patch to use that if it may ever get allowed.

FYI, I have just personally contacted Google to try and figure out if this *new* API would be useable/feasible/etc. Even if "we" must pay etc. to try and get details on this, in parallel to the other Work Karsten is doing.

I used the contact form from that bugs code comment // See http://www.google.com/support/enterprise/bin/request.py?contact_type=gme&utm_campaign=en-us-ptr-mz
Comment on attachment 554426 [details] [diff] [review]
v2: set Google geolocation provider v2 by default

"approval‑comm‑beta=?":
per
https://wiki.mozilla.org/SeaMonkey/StatusMeetings/2011-11-01#Any_other_business.3F
{
Geolocation now works out of the box. MoCo turned it on by default for all applications that build off mozilla-central.
For comm-beta all we need to do is (bug 494421) to add pref("geo.wifi.uri", "https://www.google.com/loc/json"); to browser-prefs.js. 
}

To be explicit, what about comm‑aurora?
Attachment #554426 - Flags: approval-comm-beta?
Comment on attachment 554426 [details] [diff] [review]
v2: set Google geolocation provider v2 by default

We're not even sure we are legally allowed to ship with the URL in, we might need to actually put in a pref to disable that in newer builds. Callek is on it, but we surely can't just turn a blind eye and enable it in release.
Attachment #554426 - Flags: approval-comm-beta? → approval-comm-beta-
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #5)
> Comment on attachment 554426 [details] [diff] [review]
> v2: set Google geolocation provider v2 by default
> 
> We're not even sure we are legally allowed to ship with the URL in, we might
> need to actually put in a pref to disable that in newer builds. Callek is on
> it, but we surely can't just turn a blind eye and enable it in release.

Still looking into this, and had my most recent chat regarding it this week -- nothing to report yet though. But might as well track this bug myself.
Assignee: kairo → bugspam.Callek
Callek, is this bug still good for something? It shows up in a radar of "bugs where I did patches but the bug isn't resolved"). If the bug is still valid to be around, I guess my patch is obsolete in any case.
> +pref("geo.wifi.uri", "https://maps.googleapis.com/maps/api/browserlocation/json");
These days Toolkit/Core hard codes the geolocation provider to "https://maps.googleapis.com/maps/api/browserlocation/json" if the "geo.wifi.uri" preference isn't set.
See <http://hg.mozilla.org/mozilla-central/annotate/a207f33adc1a/dom/system/NetworkGeolocationProvider.js#l198>

So I'm closing this as WFM
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.