677256 - Migrate to Google Location Service v2

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Doug Turner (:dougt)]

Google is implementing a simpler GLS service and deprecating the old one.  We will migrate.

Comment 1

[Doug Turner (:dougt)]

Attachment: New network geolocation provider

This file replaces the existing NetworkGelocationProvider.js.  It is probably best to just review this file as the diff is going to be huge.

I removed HELD support.  I contacted the contributor and he is fine with it and will probably make an Add-on.

Because of the large code change, I reintented everything to 2 space.  The last file was a mess.

Comment 2

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

This may need to be looked at by the security/privacy teams adding kw: sec-review-needed so we can triage the bug and decide yes/no.

Comment 3

[Asa Dotzler [:asa]]

Some web developers may have been using undocumented geo features that are going away with this update. We should probably add that to the "what's important for web developers" document for the release that carries this change.

Comment 4

[Doug Turner (:dougt)]

Attachment: diff w/ tests fix ups

ben, this is mostly the same as the file, but now in diff form.  I updated the tests to be compatible with the new format, and included a tri-lic header.

Comment 5

[Ian Melven :imelven]

spoke to dougt earlier and confirmed the new version of the api does not introduce any new security or privacy risks compared to the existing one in use, and in fact sends back less data. removing sec-review-needed.

Comment 6

[Doug Turner (:dougt)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/861e1307c43c

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/861e1307c43c

Comment 8

[Robert Kaiser]

(In reply to Doug Turner (:dougt) from comment #0)
> Google is implementing a simpler GLS service and deprecating the old one. 
> We will migrate.

Is that one still only for use of Firefox or can this one be used more publicly?
Just wondering if this could give bug 494421 some traction...

Comment 9

[Doug Turner (:dougt)]

Mozilla Firefox only.

Comment 10

[Robert Kaiser]

(In reply to Doug Turner (:dougt) from comment #9)
> Mozilla Firefox only.

OK, thanks, just wanted to clarify that.

Comment 11

[Eric Shepherd [:sheppy]]

Anyone aware of anything in particular that I should be documenting here? Is just saying that the back-end service has been updated enough, or are there specific details that need mentioning?

Comment 12

[Doug Turner (:dougt)]

nope.  killing the flags.

Comment 13

[Ka-Hing Cheung]

The new scheme unconditionally appends "?browser=firefox&sensor=true" to the end of geo.wifi.uri, which breaks manually setting that pref to a data uri to force a particular location. In my case I don't have wifi on this computer so I want to override the IP based detection with something more accurate. Is there a workaround?