Migrate to Google Location Service v2

RESOLVED FIXED in mozilla9

Status

()

Core
Geolocation
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

unspecified
mozilla9
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Google is implementing a simpler GLS service and deprecating the old one.  We will migrate.
(Assignee)

Comment 1

6 years ago
Created attachment 551470 [details]
New network geolocation provider

This file replaces the existing NetworkGelocationProvider.js.  It is probably best to just review this file as the diff is going to be huge.

I removed HELD support.  I contacted the contributor and he is fine with it and will probably make an Add-on.

Because of the large code change, I reintented everything to 2 space.  The last file was a mess.
Assignee: nobody → doug.turner
Attachment #551470 - Flags: review?(ben)
Attachment #551470 - Flags: review?(ben) → review+
This may need to be looked at by the security/privacy teams adding kw: sec-review-needed so we can triage the bug and decide yes/no.
Keywords: sec-review-needed

Comment 3

6 years ago
Some web developers may have been using undocumented geo features that are going away with this update. We should probably add that to the "what's important for web developers" document for the release that carries this change.
Keywords: sec-review-needed → relnote
Keywords: dev-doc-needed
Keywords: sec-review-needed
Whiteboard: [sr:imelven]
(Assignee)

Comment 4

6 years ago
Created attachment 552430 [details] [diff] [review]
diff w/ tests fix ups

ben, this is mostly the same as the file, but now in diff form.  I updated the tests to be compatible with the new format, and included a tri-lic header.
Attachment #551470 - Attachment is obsolete: true
Attachment #552430 - Flags: review?(ben)

Comment 5

6 years ago
spoke to dougt earlier and confirmed the new version of the api does not introduce any new security or privacy risks compared to the existing one in use, and in fact sends back less data. removing sec-review-needed.
Keywords: sec-review-needed
Whiteboard: [sr:imelven]
Attachment #552430 - Flags: review?(ben) → review+
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/861e1307c43c
http://hg.mozilla.org/mozilla-central/rev/861e1307c43c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9

Comment 8

6 years ago
(In reply to Doug Turner (:dougt) from comment #0)
> Google is implementing a simpler GLS service and deprecating the old one. 
> We will migrate.

Is that one still only for use of Firefox or can this one be used more publicly?
Just wondering if this could give bug 494421 some traction...
(Assignee)

Comment 9

6 years ago
Mozilla Firefox only.

Comment 10

6 years ago
(In reply to Doug Turner (:dougt) from comment #9)
> Mozilla Firefox only.

OK, thanks, just wanted to clarify that.
Depends on: 683157
Depends on: 668194
Anyone aware of anything in particular that I should be documenting here? Is just saying that the back-end service has been updated enough, or are there specific details that need mentioning?
(Assignee)

Comment 12

6 years ago
nope.  killing the flags.
Keywords: dev-doc-needed, relnote

Updated

6 years ago
Blocks: 702107

Comment 13

6 years ago
The new scheme unconditionally appends "?browser=firefox&sensor=true" to the end of geo.wifi.uri, which breaks manually setting that pref to a data uri to force a particular location. In my case I don't have wifi on this computer so I want to override the IP based detection with something more accurate. Is there a workaround?

Updated

6 years ago
Depends on: 716453
Depends on: 883071
You need to log in before you can comment on or make changes to this bug.