Closed Bug 494833 Opened 15 years ago Closed 15 years ago

Refresh all tabs button on OS X

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3.6a1

People

(Reporter: faaborg, Assigned: dao)

References

Details

(Keywords: verified1.9.1, Whiteboard: [icon-shiretoko][icon-complete][fix in bug 494659])

Attachments

(3 files, 1 obsolete file)

Refreshed all tabs button
1.10 KB, image/png
Details
Re-Open? Screenshot
59.89 KB, image/png
Details
correctly use the hit state (1.9.1-only)
833 bytes, patch
mstange
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review 
We are refreshing all of the tab strip icons on OS X (left arrow, right arrow, new tab, close, all tabs).  This bug covers all tabs.
This file needs to replace the file at /source/browser/themes/pinstripe/browser/tabbrowser/alltabs-box-bkgnd-icon.png

Also, this file adds includes (in order) the normal, hover and hit states.
Whiteboard: [icon-shiretoko][icon-complete]
(this has my pre-approval to land on mozilla-central once reviewed, please nominate for a191 when that happens)
We need to get this landed before the RC freeze.
Assignee: nobody → dao
Depends on: 494659
Attached image Refreshed and cropped all tabs button (obsolete) — 
The images are 18x20, and states are:

normal / hover / hit
Attachment #379633 - Attachment is obsolete: true
Whiteboard: [icon-shiretoko][icon-complete] → [icon-shiretoko][icon-complete][fix in bug 494659]
Comment on attachment 379633 [details]
Refreshed all tabs button

going to use this version
Attachment #379633 - Attachment is obsolete: false
Attachment #380589 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/75eb0b1d976d
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.6a1
Attached image Re-Open? Screenshot — 
This hasn't been fixed on Shiretoko on build:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090601 Shiretoko/3.5pre ID:20090601031153

A screenshot of the activated All Tabs button is attached via this comment. The minefield nightly build after 5/28 isn't out yet on OSX. I'm re-opening this bug to be on the safe side.
Have you tried this without personas?
The behavior is present when personas is disabled.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Oh right, 1.9.1 is different. Resolving for trunk and removing fixed1.9.1 for branch.
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED

        Attachment #380863 -
        Flags: review?(mstange)

        Attachment #380863 -
        Flags: review?(mstange) → review+

    
  

        Attachment #380863 -
        Flags: approval1.9.1?

    
    

    
  
Comment on attachment 380863 [details] [diff] [review]
correctly use the hit state (1.9.1-only)

a191=beltzner

        Attachment #380863 -
        Flags: approval1.9.1? → approval1.9.1+

    
    

    
  
Verified fixed on trunk and 1.9.1 with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090604 Minefield/3.6a1pre ID:20090604031228

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090604 Shiretoko/3.5pre ID:20090604031153
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
Hardware: x86 → All

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: