There is lots of code with |ifneq (,$(filter mac cocoa,$(MOZ_WIDGET_TOOLKIT)))| or the like. I checked the buildbot logs for the unit tests boxes and found |-DMOZ_WIDGET_TOOLKIT=cocoa| only. Is 'mac' used in some other cases (as in an option to disable cocoa?), or would it be a cruft of the XP_MAC (= non MacOSX) days?
it used to be old carbon widgets for Mac.
Summary: What is the current use of |DMOZ_WIDGET_TOOLKIT=mac|? → Remove obsolete "MOZ_WIDGET_TOOLKIT =/!= mac" checks
Yes, these checks can be removed, and cases like the one you highlighted can be changed to check for "cocoa" only.
Still haven't managed to stay awake clear through checking my work, but the tryserver likes it, which is nice.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #398076 - Flags: review?(ted.mielczarek)
The "Ding, dong, the xpcom/obsolete is dead" edition.
Attachment #398384 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 398384 [details] [diff] [review] Unrotted a/toolkit/profile/Makefile.in # Use Qute for non-Mac non-Phoenix apps I LOLed a little at that. Can't believe I read that entire patch, too. Thanks for the cleanup!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
The checkin in comment 6 caused a number build warnings like this to appear: > Makefile:48: Extraneous text after `ifneq' directive The "Extraneous text" is a few extra right-parens whose matching left-paren was removed in this bug's checkin. This small followup patch kills these unmatched right-parens and fixes the build warnings.
Attachment #401964 - Flags: review?
Attachment #401964 - Flags: review? → review?(ted.mielczarek)
Comment on attachment 401964 [details] [diff] [review] followup patch: remove a few trailing right-paren chars Read the whole patch and didn't catch that. Thanks!
Attachment #401964 - Flags: review?(ted.mielczarek) → review+
V.Fixed, per mxr.
Status: RESOLVED → VERIFIED
Landed followup patch: http://hg.mozilla.org/mozilla-central/rev/fbf180e8af9c
You need to log in before you can comment on or make changes to this bug.