Remove obsolete "MOZ_WIDGET_TOOLKIT =/!= mac" checks

VERIFIED FIXED in mozilla1.9.3a1

Status

defect
--
trivial
VERIFIED FIXED
10 years ago
2 years ago

People

(Reporter: sgautherie, Assigned: philor)

Tracking

Trunk
mozilla1.9.3a1
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(2 attachments, 1 obsolete attachment)

There is lots of code with |ifneq (,$(filter mac cocoa,$(MOZ_WIDGET_TOOLKIT)))| or the like.

I checked the buildbot logs for the unit tests boxes and found |-DMOZ_WIDGET_TOOLKIT=cocoa| only.

Is 'mac' used in some other cases (as in an option to disable cocoa?),
or would it be a cruft of the XP_MAC (= non MacOSX) days?
it used to be old carbon widgets for Mac.
Blocks: 281889
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: in-testsuite-
Whiteboard: [good first bug]
Summary: What is the current use of |DMOZ_WIDGET_TOOLKIT=mac|? → Remove obsolete "MOZ_WIDGET_TOOLKIT =/!= mac" checks
Yes, these checks can be removed, and cases like the one you highlighted can be changed to check for "cocoa" only.
Depends on: 509533
Posted patch rm (obsolete) — Splinter Review
Still haven't managed to stay awake clear through checking my work, but the tryserver likes it, which is nice.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #398076 - Flags: review?(ted.mielczarek)
Posted patch UnrottedSplinter Review
The "Ding, dong, the xpcom/obsolete is dead" edition.
Attachment #398076 - Attachment is obsolete: true
Attachment #398384 - Flags: review?(ted.mielczarek)
Attachment #398076 - Flags: review?(ted.mielczarek)
Attachment #398384 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 398384 [details] [diff] [review]
Unrotted

a/toolkit/profile/Makefile.in
# Use Qute for non-Mac non-Phoenix apps

I LOLed a little at that.

Can't believe I read that entire patch, too. Thanks for the cleanup!
Whiteboard: [good first bug] → [landme]
http://hg.mozilla.org/mozilla-central/rev/96f28a6332cb
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [landme]
Target Milestone: --- → mozilla1.9.3a1
The checkin in comment 6 caused a number build warnings like this to appear:
> Makefile:48: Extraneous text after `ifneq' directive

The "Extraneous text" is a few extra right-parens whose matching left-paren was removed in this bug's checkin.

This small followup patch kills these unmatched right-parens and fixes the build warnings.
Attachment #401964 - Flags: review?
Attachment #401964 - Flags: review? → review?(ted.mielczarek)
Comment on attachment 401964 [details] [diff] [review]
followup patch: remove a few trailing right-paren chars

Read the whole patch and didn't catch that. Thanks!
Attachment #401964 - Flags: review?(ted.mielczarek) → review+
V.Fixed, per mxr.
Status: RESOLVED → VERIFIED
Depends on: 463982
Depends on: 464362
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.