Closed Bug 509533 Opened 10 years ago Closed 10 years ago

Remove obsolete "MOZ_WIDGET_TOOLKIT =/!= mac" checks, in comm-central

Categories

(MailNews Core :: Build Config, defect, trivial)

x86
macOS
defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 3.1b1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

(Keywords: fixed-seamonkey2.0)

Attachments

(2 files)

No description provided.
Whiteboard: [good first bug]
Blocks: 281889
Attachment #402016 - Flags: review?(kairo)
Attachment #402016 - Flags: approval-seamonkey2.0?
Comment on attachment 402016 [details] [diff] [review]
(Av1) /suite/*/Makefile.in
[Checkin: Comment 5]

r=me, but I'll leave it up to Standard8 to grant approval as this touches both SM and TB.
Attachment #402016 - Flags: review?(kairo) → review+
Comment on attachment 402016 [details] [diff] [review]
(Av1) /suite/*/Makefile.in
[Checkin: Comment 5]


(In reply to comment #2)
> this touches both SM and TB.

The bug, yes; but this patch is its SM specific part only.
Comment on attachment 402016 [details] [diff] [review]
(Av1) /suite/*/Makefile.in
[Checkin: Comment 5]

Oh, right, didn't look carefully enough at the actual files, only at the code changes :P
Attachment #402016 - Flags: approval-seamonkey2.0? → approval-seamonkey2.0+
Comment on attachment 402016 [details] [diff] [review]
(Av1) /suite/*/Makefile.in
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/522b6f6cdcd2
Attachment #402016 - Attachment description: (Av1) /suite/*/Makefile.in → (Av1) /suite/*/Makefile.in [Checkin: Comment 5]
Attachment #422234 - Flags: review?(bugzilla)
Depends on: 543212
Attachment #422234 - Flags: review?(bugspam.Callek)
Comment on attachment 422234 [details] [diff] [review]
(Bv1) *.mk
[Checkin: Comment 9]


Callek, would your review be enough wrt /mail part?
Comment on attachment 422234 [details] [diff] [review]
(Bv1) *.mk
[Checkin: Comment 9]

I *normally* would say no for [most] mail/ but in this case I am comfortable saying yes.
Attachment #422234 - Flags: review?(bugzilla)
Attachment #422234 - Flags: review?(bugspam.Callek)
Attachment #422234 - Flags: review+
Comment on attachment 422234 [details] [diff] [review]
(Bv1) *.mk
[Checkin: Comment 9]


http://hg.mozilla.org/comm-central/rev/5da147bf90bd
Attachment #422234 - Attachment description: (Bv1) *.mk → (Bv1) *.mk [Checkin: Comment 9]
Whiteboard: [good first bug] → [ToDo: /calendar, /mail and /mailnews] [good first bug]
Status: NEW → RESOLVED
Closed: 10 years ago
Product: MailNews Core → SeaMonkey
QA Contact: build-config → build-config
Resolution: --- → FIXED
Summary: Remove obsolete "MOZ_WIDGET_TOOLKIT =/!= mac" checks, in comm-central → Remove obsolete "MOZ_WIDGET_TOOLKIT =/!= mac" checks, in SeaMonkey
Whiteboard: [ToDo: /calendar, /mail and /mailnews] [good first bug]
Phil, what now? This bug is neither SeaMonkey specific nor fixed!
Status: RESOLVED → REOPENED
Product: SeaMonkey → MailNews Core
QA Contact: build-config → build-config
Resolution: FIXED → ---
Summary: Remove obsolete "MOZ_WIDGET_TOOLKIT =/!= mac" checks, in SeaMonkey → Remove obsolete "MOZ_WIDGET_TOOLKIT =/!= mac" checks, in comm-central
Whiteboard: [ToDo: /calendar, /mail and /mailnews] [good first bug]
Status: REOPENED → NEW
Oh, true, it's a SeaMonkey bug with a target milestone of whatever last September is, and a MailNews Core+Thunderbird bug with a target milestone of whatever January was. Set whatever suits you for that combination, I filed bug 553529 for the rest of it (and had a comment about that, but I seem to have lost it when I went wandering off looking for what the SM milestone was last September).
Status: NEW → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Whiteboard: [ToDo: /calendar, /mail and /mailnews] [good first bug]
(In reply to comment #11)

> Set whatever suits you for that combination,

The most recent.

> I filed bug 553529 for the rest of it

I don't understand why you need to close this bug and open a new one just to attach a patch, but as you prefer: thanks for the patch!
Assignee: nobody → sgautherie.bz
Depends on: 553529
Flags: in-testsuite-
Target Milestone: --- → Thunderbird 3.1b1
Now V.Fixed, per mxr.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.