495230 - Error: focusedWindow.getSelection() is null in this case when iframe gets display: none

Status: REOPENED

(Toolkit :: Find Toolbar, defect, P5)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, I'm getting this error when pressing the ctl-f key with it:
Error: focusedWindow.getSelection() is null
Source File: chrome://global/content/bindings/findbar.xml
Line: 1631

I guess it shouldn't be possible for document.commandDispatcher.focusedWindow to be a display: none iframe, but since that appears to be possible, the findbar code should cope with it.

Comment 1

[Garry Yao]

Attachment: TC of making selection in non-displayed contenteditable frame

This bug affects also contenteditable frame, verified with attached TC.
See also CKEditor bug:
http://dev.ckeditor.com/ticket/6577

Comment 3

[Hallvord R. M. Steen [:hallvors]]

I think this is related to bug 585229 but I'm not sure if it's a dup or not. Boris, can we close either as a dup of the other?

Comment 4

[Boris Zbarsky [:bzbarsky]]

This is related, but not a duplicate.  Specifically, this bug is for how our UI handles the situation caused by bug 585229.