49534 - adding same bookmark >1 times requires equal number of "delete" ops to remove

Status: VERIFIED WORKSFORME

(SeaMonkey :: Bookmarks & History, defect, P2)

Description

[Chris Waterson]

To reproduce:

1. Go to a web page; e.g., http://www.mozilla.org/
2. Choose "Bookmarks->Add Current Page"
3. Repeat.
4. Go to bookmarks menu: select "Bookmarks->Manage Bookmarks"
5. Select "Mozilla.org" bookmark
6. Select "Edit->Delete"

Note that the bookmark is not removed.

7. Select "Edit->Delete" again. Now the bookmark will go away.

Expected behavior: one "delete" will kill the bookmark.

I'm sure this is happening because we're asserting into the RDF datasource
multiple times. We should probably just detect that the bookmark is already in
the folder, and refuse to bookmark it again. Or maybe not. This is tricky. rjc
will have some ideas.

Comment 1

[verah (gone)]

Nav triage team: Reassigning to rjc; recommend nsbeta3+ for this one.

Comment 2

[Daniel Veditz [:dveditz]]

Time to cut deep, [nsbeta3-]. I could be wrong, but I suspect that since 
bookmarks are stored as html this would only happen if you add and attempt to 
delete within the same session which can't be that common of a case.

Comment 3

[David Krause]

This bug depends on getting bug 51683 fixed.  When I try to Add Current Page and
then do it again and again I still only see 1 bookmark.

Comment 4

[Marcia Knous [:marcia]]

Netscape Nav triage team: this is a Netscape beta stopper. Dupe of single 
bookmarks?

Comment 5

[Paul Chen]

nav triage team:

Marking nsbeta1+

Comment 6

[Blake Ross]

nsbeta1+ and assigned to rjc, not a good combination.  -> ben (but I suspect 
this is fixed once the broken clipboard operations are fixed)

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

This appears to be fixed. 

Comment 8

[doctor__j]

Ben wrote:
> This appears to be fixed. 

The bug is only visually fixed.  Try closing bookmark manager and re-open it.
You'll see the duplicated entry appear.  Deleting ALL duplicate entries needs
"closing and reopening and deleteing" combos to be performed as many times as
the number of dupe entries.

Reopening bug.

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

you're right. OK. Duplicate bookmarks lead to other nasty woes so setting 
priority accordingly. 

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter 
email notifications caused by this by searching for 'ilikegoats'.

Comment 11

[Chris Lyon]

*** Bug 110809 has been marked as a duplicate of this bug. ***

Comment 12

[Paul Chen]

I think Ben put some code in to check for duplicate bookmarks. At any rate,
worksforme under Netscape 6.2 and a mac mozilla build from 11/18/01. Marking w4m

Comment 13

[sairuh (rarely reading bugmail)]

mass-verifying WorksForMe bugs which haven't changed since 2001.12.31.

set your search string in mail to "EmperorLondoMollari" to filter out these
messages.