495387 - A few naughty things build their tests without ENABLE_TESTS

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Make 'em behave

Side benefit of looking at the hundreds of things that aren't in a -makefiles.sh, you get to see test(s)/Makefile being created while you're doing the --disable-tests run.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: And your little accessible, too

Where by "that patch" I mean "this patch," of course.

Comment 2

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/3c2a2e6a603e

Comment 3

[Honza Bambas (:mayhemer)]

Attachment: Fix for missing ssl tests [Checkin comment 6]

Tests for security are completely missing. We must include autoconf.mk before we do 'if ENABLE_TESTS' check.

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 389223 [details] [diff] [review]
Fix for missing ssl tests [Checkin comment 6]

Phil, can you take a look please? It's darn simple :)

Comment 5

[Honza Bambas (:mayhemer)]

Comment on attachment 389223 [details] [diff] [review]
Fix for missing ssl tests [Checkin comment 6]

Switching back to Ted. If we won't get this r+'ed today I'll land w/o a review. This is too much important and too simple to wait.

Comment 6

[Honza Bambas (:mayhemer)]

Comment on attachment 389223 [details] [diff] [review]
Fix for missing ssl tests [Checkin comment 6]

http://hg.mozilla.org/mozilla-central/rev/97f2cc123118