507370 - ssltunnel may hang with 100% CPU load, breaking the tests execution

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Honza Bambas (:mayhemer)]

When client breaks the connection by force (not a bug itself) ssltunnel indefinitely loops.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: v1 [Checkin comment 2]

Clear the output buffer when we get fatal write error to break the socket thread loop, we are not able to send it out to a dead socket no more, anyway.

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 391572 [details] [diff] [review]
v1 [Checkin comment 2]

http://hg.mozilla.org/mozilla-central/rev/b61bc50678e7

Comment 3

[Honza Bambas (:mayhemer)]

Attachment: v1 (2) [Checkin comment 4,5]

Additional fix for the linux platform. I has already solved this ones for a different piece of software, I really don't know how I could forget :)

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 393190 [details] [diff] [review]
v1 (2) [Checkin comment 4,5]

http://hg.mozilla.org/mozilla-central/rev/87e2cdc2d50e

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 393190 [details] [diff] [review]
v1 (2) [Checkin comment 4,5]

>+        if (out_flags & (PR_POLL_EXCEPT | PR_POLL_ERR | PR_POLL_HUP))
>         {
>         } // PR_POLL_EXCEPT handling

Nit: update/remove the comment.

Comment 6

[Honza Bambas (:mayhemer)]

(In reply to comment #5)
> (From update of attachment 393190 [details] [diff] [review])
> >+        if (out_flags & (PR_POLL_EXCEPT | PR_POLL_ERR | PR_POLL_HUP))
> >         {
> >         } // PR_POLL_EXCEPT handling
> 
> Nit: update/remove the comment.

http://hg.mozilla.org/mozilla-central/rev/75de8ba849b2

Comment 7

[Honza Bambas (:mayhemer)]

Comment on attachment 393190 [details] [diff] [review]
v1 (2) [Checkin comment 4,5]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/1681140c9ccb

(Includes the comment update)

Comment 8

[Honza Bambas (:mayhemer)]

Attachment: As landed on 1.9.1 (=v1+v1(2)+comment update)

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d822897fa539