495436 - Leave tab area open after a tab is closed

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

Right now, when you close a tab, you're switched to the tab before in full screen (i.e) the tab area disappears.  Instead, I think it would be better if the tab area stayed open (still switched to the new selected tab).  This would give people a better sense of which one they just switched to, and also gives them the opportunity to close multiple tabs.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

How would the tab strip be dismissed? timeout?

Comment 2

[Ben Combee (:bcombee)]

You could just tap on the tab that you're viewing again to dismiss the area, right?

Comment 3

[Stuart Parmenter]

(In reply to comment #1)
> How would the tab strip be dismissed? timeout?

you'd just pan it off

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.1

Change the onmouseup method in browser.xul on the tabs box by a onclick to prevent calling hideTabs when we close a tab.


Add a property on 'Tab' to know if it's actually closing and prevent panning in the selectedTab setter in this case (if we get rid of this panTo as suggested in bug 495535 the isClosing mechanism can be remove)

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 383275 [details] [diff] [review]
Patch v0.1

Remove the "isClosing" stuff and we'll make this bug depend on bug 476703, which should be removing the ws.panTo in Browser.selectedTab

Comment 6

[Ben Combee (:bcombee)]

You could have Keyboard Cat play the tab strip off. http://playhimoffkeyboardcat.com/

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Depends on 476703

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #6)
> You could have Keyboard Cat play the tab strip off.
> http://playhimoffkeyboardcat.com/

Sorry Ben, I'm not sure to see what you mean? (It seems that I can't fully load the page in Fennec...)

Comment 9

[Ben Combee (:bcombee)]

Keyboard cat is a semi-popular meme in the US... something from TV happens then it cuts to an old video of a cat playing an organ.  Some are funny.  It's just a joke.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #9)
> Keyboard cat is a semi-popular meme in the US... something from TV happens then
> it cuts to an old video of a cat playing an organ.  Some are funny.  It's just
> a joke.
:)
That's the fault of my english comprehension, It's buggy sometimes!

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 383480 [details] [diff] [review]
Depends on 476703

Works great

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/77312c783aa0

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

verfied with beta3

Comment 14

[Aakash Desai [:aakashd]]

litmus testcase https://litmus.mozilla.org/show_test.cgi?id=7118 updated to regression test this bug.

Comment 15

[Dão Gottwald [:dao]]

bugspam