If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Sort arrows are reversed

RESOLVED FIXED in mozilla1.9.2a1

Status

()

Toolkit
Themes
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Atsushi Sakai, Assigned: Ehsan)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.2a1
x86
Windows XP
fixed1.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
The directions of sort arrows are reversed by Bug 467844.
For example, compare
old: http://mxr.mozilla.org/mozilla1.9.1/source/toolkit/themes/winstripe/global/tree/sort-asc.gif
new: http://mxr.mozilla.org/mozilla1.9.1/source/toolkit/themes/winstripe/global/tree/sort-asc.png
I think what happened as bug 93772 swapped the file names instead of the usage?  Anyway easy enough to swap it back.
Created attachment 380577 [details] [diff] [review]
Patch (v1)

This simple patch swaps the icons...
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #380577 - Flags: review?(dao)
Attachment #380577 - Flags: approval1.9.1?

Updated

8 years ago
Attachment #380577 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/b7a247d81df0
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
Comment on attachment 380577 [details] [diff] [review]
Patch (v1)

a191=beltzner

fwiw, this is the last time I approve one of these without some sort of screenshot confirmation. the risk of further regression is obviously too high :(
Attachment #380577 - Flags: approval1.9.1? → approval1.9.1+
Created attachment 380677 [details]
1.9.1 Screenshot
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b72d381d05cd
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.