467844 - Use native sort arrows for different OS themes

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Currently we are using the same gif images for all of our OS themes on Windows, I'll attach new images to use.

Markus: out of curiosity do you know where the new OS X images are stored?  They don't seem to be in the tree folder:

http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/tree/

Comment 1

[Markus Stange [:mstange]]

On OS X the sort arrows are already native. They're drawn by the system as part of the tree header cells.
I think the images sort-asc.gif and sort-dsc.gif are unused in pinstripe and can be deleted.

Comment 2

[Markus Stange [:mstange]]

It looks like GTK has the sort arrows drawn by the system, too.

Comment 3

[Phil Ringnalda (:philor)]

faaborg: did you forget about the attachment? Is it pretty-pretty-please not going to be that non-native even for Classic (the only place it looks tolerable) embossed image for non-Vista? Kinda blocking switching Thunderbird away from its forked version of tree.css, since using toolkit's current sort images would be an ugly regression.

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

>Kinda blocking switching Thunderbird
>away from its forked version of tree.css, since using toolkit's current sort
>images would be an ugly regression.

Sorry, didn't realize I was blocking anything, I'll try to get the images up when I'm at work on monday.

Comment 5

[Phil Ringnalda (:philor)]

No worries, it's only "kinda blocking" since I just kinda noticed that side-effect of a patch we've been dragging our feet on for ten months already ;)

Comment 6

[Phil Ringnalda (:philor)]

And I bet now you're off for the holidays, and can't attach the non-ugly sort arrows, aren't you?

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

I'm working remotely at the moment and need to set up some other machines to get the images on all platforms, I'll try to get them posted soon, and definitely before freeze.

Comment 8

[Phil Ringnalda (:philor)]

(In reply to comment #7)
> I'm working remotely at the moment and need to set up some other machines to
> get the images on all platforms, I'll try to get them posted soon, and
> definitely before freeze.

That's the freeze January 13th, next Tuesday, right?

Comment 9

[Magnus Melin [:mkmelin]]

Alex, any ata on those new images?

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

eta of sometime next week, I'm getting the various images refreshed in order of priority and these arrows are currently last on the list of things to clean up before freeze (but the plan is to still make sure everything ultimately gets in on time).

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: Windows column sort arrows

This zip includes includes images for the ascending and descending column sort arrows for:

xp luna
vista aero
windows classic

the files should land to /toolkit/themes/winstripe/global/tree/

Comment 12

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: windows classic exception

There is one problem with the attached files, when in windows classic the column sort arrows are actually drawn with ThreeDShadow, so here with the hideous purple theme we see that the arrow is drawn in dark hideous purple.

The attached pngs are 128,128,128 which matches both the Windows Classic and Windows Standard OS themes.

Comment 13

[(no longer active)]

Attachment: Patch (v1)

Comment 14

[Dão Gottwald [:dao]]

Comment on attachment 379409 [details] [diff] [review]
Patch (v1)

>-        skin/classic/global/tree/sort-asc.gif                    (tree/sort-asc.gif)
>-        skin/classic/global/tree/sort-dsc.gif                    (tree/sort-dsc.gif)

Again, remove on trunk but leave on branch.

>+        skin/classic/global/tree/sort-asc.png                    (tree/sort-asc-luna.png)
>+        skin/classic/global/tree/sort-dsc.png                    (tree/sort-dsc-luna.png)

Please drop the luna suffix.

Comment 15

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/87050e30de61

Comment 16

[(no longer active)]

Attachment: 1.9.1 Patch

This patch doesn't remove the existing images.

Comment 17

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 380192 [details] [diff] [review]
1.9.1 Patch

a191=beltzner

Comment 18

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/cbf6166b7971

Comment 19

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.

general widget bugs like this are picking up P1 since they appear throughout the interface in a lot of different places (even though they are not in the main window.