Closed Bug 467844 Opened 16 years ago Closed 16 years ago

Use native sort arrows for different OS themes

Categories

(Toolkit :: Themes, defect)

All
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: faaborg, Assigned: ehsan.akhgari)

References

Details

(Keywords: fixed1.9.1, polish, Whiteboard: [polish-easy] [polish-visual][icon-shiretoko][icon-complete][polish-p1])

Attachments

(4 files)

Currently we are using the same gif images for all of our OS themes on Windows, I'll attach new images to use. Markus: out of curiosity do you know where the new OS X images are stored? They don't seem to be in the tree folder: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/tree/
Keywords: polish, uiwanted
Whiteboard: [polish-easy] [polish-visual]
On OS X the sort arrows are already native. They're drawn by the system as part of the tree header cells. I think the images sort-asc.gif and sort-dsc.gif are unused in pinstripe and can be deleted.
It looks like GTK has the sort arrows drawn by the system, too.
faaborg: did you forget about the attachment? Is it pretty-pretty-please not going to be that non-native even for Classic (the only place it looks tolerable) embossed image for non-Vista? Kinda blocking switching Thunderbird away from its forked version of tree.css, since using toolkit's current sort images would be an ugly regression.
Blocks: 418623
>Kinda blocking switching Thunderbird >away from its forked version of tree.css, since using toolkit's current sort >images would be an ugly regression. Sorry, didn't realize I was blocking anything, I'll try to get the images up when I'm at work on monday.
No worries, it's only "kinda blocking" since I just kinda noticed that side-effect of a patch we've been dragging our feet on for ten months already ;)
And I bet now you're off for the holidays, and can't attach the non-ugly sort arrows, aren't you?
I'm working remotely at the moment and need to set up some other machines to get the images on all platforms, I'll try to get them posted soon, and definitely before freeze.
(In reply to comment #7) > I'm working remotely at the moment and need to set up some other machines to > get the images on all platforms, I'll try to get them posted soon, and > definitely before freeze. That's the freeze January 13th, next Tuesday, right?
Alex, any ata on those new images?
eta of sometime next week, I'm getting the various images refreshed in order of priority and these arrows are currently last on the list of things to clean up before freeze (but the plan is to still make sure everything ultimately gets in on time).
Whiteboard: [polish-easy] [polish-visual] → [polish-easy] [polish-visual][icon-3.1][icon-needed]
This zip includes includes images for the ascending and descending column sort arrows for: xp luna vista aero windows classic the files should land to /toolkit/themes/winstripe/global/tree/
Keywords: uiwanted
Whiteboard: [polish-easy] [polish-visual][icon-3.1][icon-needed] → [polish-easy] [polish-visual][icon-3.1][icon-complete]
There is one problem with the attached files, when in windows classic the column sort arrows are actually drawn with ThreeDShadow, so here with the hideous purple theme we see that the arrow is drawn in dark hideous purple. The attached pngs are 128,128,128 which matches both the Windows Classic and Windows Standard OS themes.
Whiteboard: [polish-easy] [polish-visual][icon-3.1][icon-complete] → [polish-easy] [polish-visual][icon-shiretoko][icon-complete]
OS: All → Windows Vista
Version: unspecified → Trunk
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan.akhgari
Status: NEW → ASSIGNED
Attachment #379409 - Flags: review?(gavin.sharp)
Attachment #379409 - Flags: review?(gavin.sharp) → review?(dao)
Comment on attachment 379409 [details] [diff] [review] Patch (v1) >- skin/classic/global/tree/sort-asc.gif (tree/sort-asc.gif) >- skin/classic/global/tree/sort-dsc.gif (tree/sort-dsc.gif) Again, remove on trunk but leave on branch. >+ skin/classic/global/tree/sort-asc.png (tree/sort-asc-luna.png) >+ skin/classic/global/tree/sort-dsc.png (tree/sort-dsc-luna.png) Please drop the luna suffix.
Attachment #379409 - Flags: review?(dao) → review+
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Attached patch 1.9.1 PatchSplinter Review
This patch doesn't remove the existing images.
Attachment #380192 - Flags: approval1.9.1?
Attachment #380192 - Flags: approval1.9.1? → approval1.9.1+
Depends on: 495595
This bug's priority relative to the set of other polish bugs is: P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day. general widget bugs like this are picking up P1 since they appear throughout the interface in a lot of different places (even though they are not in the main window.
Whiteboard: [polish-easy] [polish-visual][icon-shiretoko][icon-complete] → [polish-easy] [polish-visual][icon-shiretoko][icon-complete][polish-p1]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: