495642 - Impossible to go to the next unread message using keyboard shortcut (N) when messages are collapsed in a thread

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Valery Kondakoff]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-GB; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1pre) Gecko/20090529 Shredder/3.0b3pre

When there are several message collapseds in a thread, it is impossible to go to the first unread message in a thread using the keyboard shortcut 'N'.
When you hit 'N' in the last message before the collapsed thread, the focus goes to the collapsed thread and the user sees the summary page instead of message body. When the user hit 'N' again the focus moves to the second message in the thread, so the first message in the thread is ignored.

Reproducible: Always

Comment 1

[Joe Sabash [:JoeS1]]

The next unread message flashes up briefly after the summary, but is not viewable.
Seems the summary page should yield to the "next unread" rendering, or "backup" to it after the summary display.

Comment 2

[David :Bienvenu]

yeah, I'm working on this. Taking.

Comment 3

[David :Bienvenu]

Attachment: proposed fix

this does two things - if we're sitting on a collapsed thread, make navigation start one before the current message, so we'll hit the next message. And make navigation that lands on a top-level collapsed message expand that thread so we'll select the message.

Comment 4

[David :Bienvenu]

Comment on attachment 380735 [details] [diff] [review]
proposed fix

this isn't quite right because of the thread-level navigations, i.e., next unread thread and kill thread. I think I need to not back up in the case of those two types of navigation. But I think the patch is a big improvement for next unread...

Comment 5

[Phil Ringnalda (:philor)]

It's a big improvement for next unread *within a single folder* - for cross-folder next unread it's a huge regression, since for some reason it breaks selecting anything in the new folder.

Comment 6

[David :Bienvenu]

inneresting - I'll fix the thread case, and look into that at the same time.

Comment 7

[David :Bienvenu]

Attachment: proposed fix, v2

I couldn't quite create failing to be able to ever load a message in the cross-navigation case, but this makes it so it loads it first time for me.

Comment 8

[David :Bienvenu]

putting in b3 - I miss this patch when running a build w/o it.

Comment 9

[Ronald Killmer]

Looking forward to testing Your patch in a nightly. I run Shredder as a news reader only for testing, so picked up on this bug in the first thread I hit with the 06/01/2009 Win32 build.

Comment 10

[Phil Ringnalda (:philor)]

Comment on attachment 380758 [details] [diff] [review]
proposed fix, v2

That seems to work, thanks.

Comment 11

[Ilja Sekler]

With this patch, if a previous, directly adjacent thread is collapsed and unread, hitting "N" or the space key while in the thread preview will jump to the 2nd message in the _previous_ thread.

Comment 12

[Thomas Stache]

This hasn't been mentioned here explicitly, but does the patch address the "mark as read"-timer, which currently ticks while the thread summary is shown. When the timer expires, the first message is marked read, although never shown. (20090601 Shredder nightly)

Comment 13

[David :Bienvenu]

Ilja - good point; either I have to special case next unread in the javascript even further, or I need to push this logic into nsMsgDBView.cpp.

Thomas, I think that issue is fixed by not loading the first message, i.e., the fix in bug 495304 awaiting sr.

Comment 14

[David :Bienvenu]

Attachment: fix addressing last comment

just check for this situation by hand so I don't have to message with viewNavigate

Comment 15

[Ilja Sekler]

Is it intended that with the both patches <https://bugzilla.mozilla.org/attachment.cgi?id=381100> and <https://bugzilla.mozilla.org/attachment.cgi?id=380506> applied, the thread summary will never show up when navigating with the keyboard?

Shouldn't it be

1. the last message in thread 1 is displayed

hit 'N':

2. the thread summary for the still collapsed thread 2 is shown

hit 'N':

3. the thread 2 is expanded, the first message is displayed

instead? The state 2 is skipped now unless you click on the collapsed thread.

Comment 16

[David :Bienvenu]

that was my intent, yes. If I say I want to read the next unread message, I want to read the next unread message. Davida was interested in a pref to control this behavior, and I think that's worth exploring as well.

Comment 17

[M.J.G.]

(In reply to comment #16)
> that was my intent, yes. If I say I want to read the next unread message, I
> want to read the next unread message. Davida was interested in a pref to
> control this behavior, and I think that's worth exploring as well.

Maybe easier (?): Distinguish between "T" and "N". If we move to next unread thread display the summary (and don't mark the first message read). If we move to the next unread message then do just that ;)

Comment 18

[Mark Banner (:standard8)]

Comment on attachment 381100 [details] [diff] [review]
fix addressing last comment

This is definitely better than what we do now, sr=Standard8.

I think comment 17 is also worth considering, though potentially in a different bug.

Comment 19

[David :Bienvenu]

I agree that treating T differently is worth considering...

Comment 20

[David :Bienvenu]

fix checked in.  Bug 496575 filed for follow up issue.

Comment 21

[Valery Kondakoff]

When I position my mouse on a first message in an unread collapsed thread in my Mail box and hitting 'N' - the first message in this thrad is displayed.

But when I do the same in an unread collapsed thread in a News account the second message in the thread is displayed and the first message becomes read. I think ths should be fixed as well.

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1pre) Gecko/20090608 Shredder/3.0b3pre

Comment 22

[David :Bienvenu]

this works for me with a newsgroup. In any case, can you file a follow-up bug for the newsgroup case?

Comment 23

[Joe Sabash [:JoeS1]]

(In reply to comment #21)
> When I position my mouse on a first message in an unread collapsed thread in my
> Mail box and hitting 'N' - the first message in this thrad is displayed.
> 
> But when I do the same in an unread collapsed thread in a News account the
> second message in the thread is displayed and the first message becomes read. I
> think ths should be fixed as well.
> 
> Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1pre) Gecko/20090608
> Shredder/3.0b3pre

Things sometimes change quickly on the trunk.
I'm not seeing this in:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090616 Lightning/1.0pre Shredder/3.0b3pre ID:20090616031827

Comment 24

[Ronald Killmer]

My observation is the summary per thread is broken and n key nav is working like normal as a result when viewing mozilla.support.firefox and other news servers.