495831 - [IE 6] Layout regressions in homepage using Internet Explorer 6

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

Layout for IE 6 looks bad on http://support-stage.mozilla.org/en-US/kb/; take a look at the screenshot.

Comment 1

[Paul Craciunoiu [:paulc]]

Stephen: are these visible on production? Hope it's just a 1.1 bug.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #1)
> Stephen: are these visible on production? Hope it's just a 1.1 bug.

Yeah, it exists on production too.

Comment 3

[Paul Craciunoiu [:paulc]]

Any idea when it showed up? I'll look at the 1.0.2 bugs when I have time...

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Sorry, I don't know -- if I had to hazard a guess, maybe your fix to reduce the Admin-menu double-spacing?

Comment 5

[Paul Craciunoiu [:paulc]]

(In reply to comment #4)
> Sorry, I don't know -- if I had to hazard a guess, maybe your fix to reduce the
> Admin-menu double-spacing?
Yeah, that's probably it. I'll try to fix this for 1.3

Comment 6

[Paul Craciunoiu [:paulc]]

Looking at this more closely, it doesn't seem to be a regression of the admin menu. Maybe a regression of something else?

Comment 7

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

This works for IE6. Not sure how it affects IE7 or 8.

Comment 8

[Paul Craciunoiu [:paulc]]

jsocol: since I hear you're a front-end guy, care to review this patch for me?

Comment 9

[James Socol [:jsocol, :james]]

Seemed to cause problems in IE7. Specifically the "clear:both;" instruction, which is missing the leading _.

There's already an IE6 specific style sheet (mozcommon/ie.css) included via conditional comment, which is safer than the underscore hack. I've moved your changes into a new patch to the IE6 style sheet.

Comment 10

[James Socol [:jsocol, :james]]

Attachment: patch, v2

Moves changes to the IE6 style sheet.

Comment 11

[Paul Craciunoiu [:paulc]]

Comment on attachment 387810 [details] [diff] [review]
patch, v1

Thanks, I knew that was there somewhere! I guess I forgot about it. Anyway, ask for a review for that patch so I can r+ it :)

Comment 12

[Paul Craciunoiu [:paulc]]

Comment on attachment 394061 [details] [diff] [review]
patch, v2

Looks good on IE6.

Comment 13

[Paul Craciunoiu [:paulc]]

r49051 / r49052
Solved for IE6. James found some issues for IE7 and he's on it, bug 510072

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks, James!