Closed Bug 495940 Opened 10 years ago Closed 10 years ago

Rename Folder dialog don't use a verb for the confirm button

Categories

(Thunderbird :: Folder and Message Lists, defect, minor)

defect
Not set
minor

Tracking

(thunderbird3.1 beta2-fixed)

RESOLVED FIXED
Thunderbird 3.1b2
Tracking Status
thunderbird3.1 --- beta2-fixed

People

(Reporter: andreasn, Assigned: ewong)

Details

Attachments

(2 files, 1 obsolete file)

Attached image current dialog
According to the Interface guidelines for both Vista, OS X and GNOME, it's
preferred to use a verb instead of a standard button labeled OK. 

I would suggest "Rename" instead.
Rename sounds good to me
Assignee: nobody → edmund
Status: NEW → ASSIGNED
Assignee: edmund → nobody
Severity: normal → minor
Component: General → Folder and Message Lists
QA Contact: general → folders-message-lists
Assignee: nobody → edmund
Aside for labeling the Rename button,  it seems as if the License information 
was also missing for renameFolderDialog.dtd.  I have copy and pasted the 
appropriate license to the file.
Attachment #432077 - Flags: review?(clarkbw)
Attachment #432077 - Flags: ui-review?(nisses.mail)
Comment on attachment 432077 [details] [diff] [review]
Rename button changed to "Rename"

looks good to me, but I'm going to pass this off to someone qualified. :)

Magnus, do you mind taking this one?
Attachment #432077 - Flags: review?(clarkbw) → review?(mkmelin+mozilla)
Comment on attachment 432077 [details] [diff] [review]
Rename button changed to "Rename"

Tried on both Linux and Windows and looks good (I suspect it looks fairly identical on the mac). Great work Edmund!
Attachment #432077 - Flags: ui-review?(nisses.mail) → ui-review+
Comment on attachment 432077 [details] [diff] [review]
Rename button changed to "Rename"

Looks good to me, r=mkmelin

I'm unsure about the license block though. (If suite want's it in dtds, and the dates/original code statement is likely wrong.) I'll leave that up to suite reviewer though.
Attachment #432077 - Flags: review?(mkmelin+mozilla) → review+
OS: Linux → All
Hardware: x86 → All
Target Milestone: --- → Thunderbird 3.1b2
rs=Callek for suite file not having license header.
Attachment #432077 - Attachment is obsolete: true
Attachment #433869 - Attachment description: same as [x] but without boilerplate → same as v1 but without boilerplate
Attachment #433869 - Attachment is patch: true
Attachment #433869 - Attachment mime type: application/octet-stream → text/plain
Please get superreview for this so it can land (neil@httl.net perhaps)?
Attachment #433869 - Flags: superreview?(neil)
(In reply to comment #7)
> Please get superreview for this so it can land (neil@httl.net perhaps)?

Thanks.  Lost track of this bug.
Attachment #433869 - Flags: superreview?(neil) → superreview+
Checked in: http://hg.mozilla.org/comm-central/rev/09f9b08324d0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.