Closed
Bug 496368
Opened 15 years ago
Closed 15 years ago
Add CCNightlyRepackFactory/CCBaseRepackFactory to buildbotcustom
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kairo, Assigned: kairo)
References
Details
Attachments
(1 file, 1 obsolete file)
|
4.70 KB,
patch
|
bhearsum
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
When the abstraction of the generic classes in bug 494577 is done, we can add the CCNightlyRepackFactory and CCBaseRepackFactory subclasses to buildbotcustom, which I have prototyped and stabilized in http://hg.mozilla.org/users/kairo_kairo.at/bbconf-sm2/file/tip/ccfactory.py for now and which care to override as little as possible of the common base classes.
|
Assignee | |
Comment 1•15 years ago
|
||
Once again, our abstraction of the base classes works out very nicely and those comm-central classes are fairly small. :)
Attachment #381555 -
Flags: review?(bhearsum)
|
|
Assignee | |
Comment 2•15 years ago
|
||
unbitrot the patch, cleanly applies to buildbotcustom rev. 2c8a4ab0c551 on top of latest bug 494577 patch.
Attachment #381555 -
Attachment is obsolete: true
Attachment #387042 -
Flags: review?(bhearsum)
Attachment #381555 -
Flags: review?(bhearsum)
|
||
Comment 3•15 years ago
|
||
I did a mock release with this patch today and it went great. I'll do an actual review tomorrow.
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 387042 [details] [diff] [review] unbitrot the patch These are nice and compact :-)
Attachment #387042 -
Flags: review?(bhearsum) → review+
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 387042 [details] [diff] [review] unbitrot the patch changeset: 363:5ef07b7dbc50
Attachment #387042 -
Flags: checked‑in+
|
|
Assignee | |
Comment 6•15 years ago
|
||
Thanks for checking in, marking fixed as the patch seems to stick.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•