Add CCNightlyRepackFactory/CCBaseRepackFactory to buildbotcustom

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
5 years ago

People

(Reporter: kairo, Assigned: kairo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
When the abstraction of the generic classes in bug 494577 is done, we can add the CCNightlyRepackFactory and CCBaseRepackFactory subclasses to buildbotcustom, which I have prototyped and stabilized in http://hg.mozilla.org/users/kairo_kairo.at/bbconf-sm2/file/tip/ccfactory.py for now and which care to override as little as possible of the common base classes.
(Assignee)

Comment 1

9 years ago
Created attachment 381555 [details] [diff] [review]
add the comm-central repack factories

Once again, our abstraction of the base classes works out very nicely and those comm-central classes are fairly small. :)
Attachment #381555 - Flags: review?(bhearsum)
(Assignee)

Updated

9 years ago
Blocks: 498110
(Assignee)

Comment 2

9 years ago
Created attachment 387042 [details] [diff] [review]
unbitrot the patch

unbitrot the patch, cleanly applies to buildbotcustom rev. 2c8a4ab0c551 on top of latest bug 494577 patch.
Attachment #381555 - Attachment is obsolete: true
Attachment #387042 - Flags: review?(bhearsum)
Attachment #381555 - Flags: review?(bhearsum)
I did a mock release with this patch today and it went great. I'll do an actual review tomorrow.
Comment on attachment 387042 [details] [diff] [review]
unbitrot the patch

These are nice and compact :-)
Attachment #387042 - Flags: review?(bhearsum) → review+
Comment on attachment 387042 [details] [diff] [review]
unbitrot the patch

changeset:   363:5ef07b7dbc50
Attachment #387042 - Flags: checked‑in+
(Assignee)

Comment 6

9 years ago
Thanks for checking in, marking fixed as the patch seems to stick.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.