Closed Bug 496454 Opened 10 years ago Closed 10 years ago

Colors in the menu bar on Linux

Categories

(Toolkit :: Themes, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: faaborg, Assigned: ventnor.bugzilla)

References

(Depends on 1 open bug)

Details

(Keywords: polish, Whiteboard: [polish-easy] [polish-visual][polish-p1])

Attachments

(1 file)

Thomas Wood who works on the gnome themes writes:

>While we're on the topic of GTK/Firefox integration however, I would
>like to raise a pet bug of my own. It seems that Firefox will use the
>text colour for the menubar items from the menu item object. However,
>when the items are not selected, they should use the fg colour from the
>menubar, since non-selected menu items are transparent. This causes
>problems in themes where the menu bar is a different colour to menu
>items, and can cause the menu items in the menu bar to become invisible
>because of the mismatch in colours.
Whiteboard: [polish-easy] [polish-visual]
I can do this. It'll hopefully be possible for 3.5.
Component: Theme → Themes
Product: Firefox → Toolkit
QA Contact: theme → themes
Attached patch PatchSplinter Review
This does it. New Wave (which is the most awesome theme I've ever seen, even though its incomplete) shows this bug, and it's a default Ubuntu theme.
Assignee: nobody → ventnor.bugzilla
Status: NEW → ASSIGNED
Attachment #381902 - Flags: superreview?(roc)
Attachment #381902 - Flags: review?(roc)
Attachment #381902 - Flags: superreview?(roc)
Attachment #381902 - Flags: superreview+
Attachment #381902 - Flags: review?(roc)
Attachment #381902 - Flags: review+
m-c is open for general checkins, right?
Keywords: checkin-needed
Whiteboard: [polish-easy] [polish-visual] → [polish-easy] [polish-visual] [needs landing]
(In reply to comment #3)
> m-c is open for general checkins, right?

no, you need explicit approval for m-c or for 1.9.1.
http://hg.mozilla.org/mozilla-central/rev/dd109d204029
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [polish-easy] [polish-visual] [needs landing] → [polish-easy] [polish-visual]
Target Milestone: --- → mozilla1.9.2a1
This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.
Whiteboard: [polish-easy] [polish-visual] → [polish-easy] [polish-visual][polish-p1]
Thanks for fixing this Michael, much appreciated! We're going to try and include this patch in Moblin, as we are affected by this issue with our theme as well.
You need to log in before you can comment on or make changes to this bug.