496454 - Colors in the menu bar on Linux

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

Thomas Wood who works on the gnome themes writes:

>While we're on the topic of GTK/Firefox integration however, I would
>like to raise a pet bug of my own. It seems that Firefox will use the
>text colour for the menubar items from the menu item object. However,
>when the items are not selected, they should use the fg colour from the
>menubar, since non-selected menu items are transparent. This causes
>problems in themes where the menu bar is a different colour to menu
>items, and can cause the menu items in the menu bar to become invisible
>because of the mismatch in colours.

Comment 1

[Michael Ventnor]

I can do this. It'll hopefully be possible for 3.5.

Comment 2

[Michael Ventnor]

Attachment: Patch

This does it. New Wave (which is the most awesome theme I've ever seen, even though its incomplete) shows this bug, and it's a default Ubuntu theme.

Comment 3

[Michael Ventnor]

m-c is open for general checkins, right?

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> m-c is open for general checkins, right?

no, you need explicit approval for m-c or for 1.9.1.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/dd109d204029

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P1 - Polish issue that appears in the main window, or is something that the user may encounter several times a day.

Comment 7

[Thomas Wood]

Thanks for fixing this Michael, much appreciated! We're going to try and include this patch in Moblin, as we are affected by this issue with our theme as well.