496625 - creation of auto-publisher named "superman" fails:error message is not in red

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[krupa raj[:krupa]]

Attachment: error message

steps to reproduce:
1.Install the latest collector extension
2.Tools->Add-ons->Extensions
3.Add-on Collector->Preferences->Auto-publisher settings
4.Try to create an auto-publisher with the name-"superman"
5.creation fails with an internal error
6.Trying creating an auto-publisher with the name-"spiderman"
7.Creation is successful.Delete the auto-publisher
8.Repeat step #4
9.Creation fails once agian.This time notice the color of the error message.

expected result:
-auto-publisher with the name-"superman" is successful
-error/failure messages are in red

actual result:
-auto-publisher with the name-"superman" is unsuccessful
- After step #9,error/failure message is in green

additional info:
-creation of auto-publisher with names of other super-heroes works fine

Comment 1

[Brian King [:kinger]]

(In reply to comment #0)
> additional info:
> -creation of auto-publisher with names of other super-heroes works fine

Superman is not one of the most popular superheroes, so this is an edge-case. If it failed on Batman, this would have to be a blocker :)

Comment 2

[krupa raj[:krupa]]

(re comment 1)

Agreed.No one is cooler than the caped crusader.But we shouldn't slight the "Man of Steel".He is known to hurl cars at people who displease him ;)

Comment 3

[David McNamara [:mackers]]

Ok. I've fixed the color issue. (Not that I can tell the difference without resorting to the eyedropper ;)

r27496.

The "superman" issue is something else. I suspect it doesn't work because there is already a superman collection on the server. 

The API doesn't tell us much:

<error reason="invalid_parameters" details="nickname"/>

Some solutions:

1) improve error message to inform user that the name might already be taken.

2) Add a nickname field. The nickname is taken from the collection name. The nickname has to be unique, not the collection name.

3) If the API call fails with this message, we could try auto-generating a nickname, e.g. "superman3452"

Comment 4

[Brian King [:kinger]]

(In reply to comment #3)
> The "superman" issue is something else. I suspect it doesn't work because there
> is already a superman collection on the server. 
> 
> The API doesn't tell us much:

Filed bug 497419. Closing this one.

Comment 5

[krupa raj[:krupa]]

error message looks ok now.Filed a related bug- Bug 498682 .verified