496672 - Sometimes getting a blank Popular Collections page when using ?sortby=all

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

URL: https://preview.addons.mozilla.org/en-US/firefox/collections/popular?sortby=all

The server responds to a GET request for the above URL sometimes with 200 OK, with a content-length of 0.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Headers

Comment 2

[Justin Scott [:fligtar]]

I can reproduce this, as could several others on IRC.

Jeff, I think you made this page -- could you take a look please?

Comment 3

[Jeff Balogh (:jbalogh)]

I think we would see an empty page if php hits a bad error–that's where I've seen empty pages like this on my dev box.  It would help to set DEBUG=1 on preview so we can see what the error is.  

I'll be flying today, so if someone could look at this before Sunday, that would be great.

Comment 4

[Justin Scott [:fligtar]]

Jeremy, could you set DEBUG to 1 on preview please?

Comment 5

[Jeff Balogh (:jbalogh)]

Fixed in r27311.  We were trying to bind models when they were already unbound.  This patch makes bindOnly more resilient, but the root problem is in bug 496834.

QA: if you hit the page twice, the collections will be cached the first time and pulled from cache the second time.  Hitting the cache was leading to this problem.  If you can refresh without seeing an issue, assume all is well.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks, Jeff -- all is well indeed.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"

Comment 8

[Jeff Balogh (:jbalogh)]

<3 stephend