497201 - E-mail address not optional for anonymous users AND the warning wipes all their text

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task, P1)

Description

[[:Cww]]

STR:

Go to http://support-stage.mozilla.org/tiki-view_forum.php?locale=en-US&forumId=1&openpost=1
Put in a question and a description
Leave Name and Email empty
Fill out the captcha
Submit
Get warning "Before you can send us your question, please enter valid information for the highlighted fields." indicating that a valid name and e-mail are necessary

Expected results: Name and e-mail should be OPTIONAL.

Comment 1

[Majken Connor [:Kensie]]

FTR email isn't necessary. If you enter a name it works fine.

Comment 2

[Paul Craciunoiu [:paulc]]

Attachment: patch v1

Couldn't help landing a patch for this, since I did that validation :)

Comment 3

[Paul Craciunoiu [:paulc]]

Comment on attachment 382422 [details] [diff] [review]
patch v1

Patch in bug 502862 will take care of this bug as well, since they overlap in code and this is a simple fix.

Comment 4

[David Tenser [:djst]]

(In reply to comment #0)
> Expected results: Name and e-mail should be OPTIONAL.

Name should NOT be optional. E-mail should be optional.

Paul, please also note the second part of this bug report: "the warning wipes all their text." When the form doesn't validate, the main body for the question is cleared. I can't even begin to imagine how frustrating this must be for the users who have hit this bug. :(

Comment 5

[David Tenser [:djst]]

The warning also wipes the Extension textarea.

Comment 6

[[:Cww]]

if you enter an email and not a name, though, you get listed as Anonymous.  I'd prefer that to forcing them to enter a name.

Comment 7

[Paul Craciunoiu [:paulc]]

Sounds like the verdict is: (one OR the other) is required. And also not wiping their text :)

Comment 8

[[:Cww]]

I still think that you should be able to be fully anonymous (enter neither).  But yes, also not wiping text.

Comment 9

[Paul Craciunoiu [:paulc]]

Attachment: patch, v2

We should really make this for 1.2.1

Comment 10

[Paul Craciunoiu [:paulc]]

Attachment: patch, v3

I apologize for spamming everyone. I was playing around with this and I missed the fields for browser + os... Hence, v3. We use a different template for Firefox forum vs Contributors forum and that caused some problems too, and really got me confused at first.

The patch above takes care of both this and bug 502862. I figured I'll attach the patch here since this is the bug that holds most of the discussion relevant to what the patch does.

Because bug 502862 relates to max-length of user field and this one is about making user + email optional, they overlap in code, and as such I've filed one patch for both. I hope this won't be a problem, as the code changes for bug 502862 are much fewer.

What this patch does:
* makes sure the fields on both Firefox and Contributors forums persist both through "Preview" and "Post" if certain information is invalid
* makes name and user optional for logged out users
* takes care of bug 502862 (adds a maxlength to the username field)

Comment 11

[Paul Craciunoiu [:paulc]]

* takes care of bug 493069 (adds highlighting for contributors forum fields on invalid submission)

Comment 12

[David Tenser [:djst]]

(In reply to comment #8)
> I still think that you should be able to be fully anonymous (enter neither). 
> But yes, also not wiping text.

That's fine with me. The important thing here is that the e-mail is optional, but on second thought I don't really have a good reason for why we would _require_ a name if it defaults to anonymous. So, the verdict is really "neither name nor email should be required". 

Paul, sounds like that was what your patch is doing too - correct?

Comment 13

[Chris Ilias [:cilias]]

My vote: require a name. Particularly if anonymous users can reply to existing threads.  A common issue with forums that allow anonymous posting is that you get no-one filling in that field, so when two or more anonymous users post in the same thread, they are identified with the same alias.

Comment 14

[[:Cww]]

We have Anonymous posting right now (name is not required).  Let's leave the bug as is and open a new one for requiring it.  (This bug is more for the fact that the message is deceptive and results in dataloss.)

djst and I discussed this and it makes the most sense to take this patch so it can make the next sumo push and delay any decision on the Anonymous posting to forumUX.

Comment 15

[Paul Craciunoiu [:paulc]]

r30142 / r30144

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I just posted http://support-stage.mozilla.org/tiki-view_forum_thread.php?locale=en-US&forumId=1&comments_parentId=374566 without any problems.

Comment 17

[[:Cww]]

What happened to the "Firefox user" text?

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #17)
> What happened to the "Firefox user" text?

Where do you see that specified in this bug?  Or, is that pre-existing text?  (If the latter, I'll try to remember for next time.)

Comment 19

[[:Cww]]

unregistered posters to the Firefox forum on prod get a Firefox user text under their name.

Comment 20

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #19)
> unregistered posters to the Firefox forum on prod get a Firefox user text under
> their name.

And they still do for me, on http://support-stage.mozilla.org/tiki-view_forum_thread.php?comments_parentId=374569&forumId=1 and http://support-stage.mozilla.org/tiki-view_forum.php?forumId=1.

Can you file a bug with what you're seeing?  Thanks!