497313 - Leading/trailing whitespaces in custom.properties and mui.properties should be removed according to the spec of the properties files

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Francesco Lodolo [:flod]]

Leading/trailing whitespaces in custom.properties and mui.properties are not ignored. We realized this issue after finding an extra whitespace in the menu item for "Safe mode" in a localized build (Italian).

This was already fixed for override.properties in bug 344148

Comment 1

[Axel Hecht [:Pike]]

Not sure if fixing this carries a risk of breaking locales that actually use the whitespace hanging around in custom.properties and the other one. Requesting wanted1.9.1.x, too.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Axel, could you take a look at this especially regarding the affect it might have on locales.

Comment 3

[Axel Hecht [:Pike]]

I found a few locales via grep that will be affected, I gotta do some test builds and go through a few install runs.

In regular strings that are displayed in a single UI blob, does the code remove surrounding whitespace at the windows layout level?

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 382569 [details] [diff] [review]
patch rev1

Going to take care of this in bug 497313

Comment 5

[Robert Strong (they/them - no direct email)]

(In reply to comment #4)
> Comment on attachment 382569 [details] [diff] [review]
> patch rev1
> 
> Going to take care of this in bug 497313
bug 570689 that is

Comment 6

[Robert Strong (they/them - no direct email)]

This is fixed on trunk by the landing of attachment #460994 [details] [diff] [review] in bug 570689 so resolving fixed.