497338 - After upgrade, folders whose view mode was set to "Unread" display "0" instead.

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Wayne Mery (:wsmwk)]

with tryserver build for  Bug 474701

view shows as 0, expected All.
I don't see after having changed the view and restart, so perhaps happens only on first startup with tryserver build.

** littlebird theme on laptop

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

This is actually an improvement against trunk and not a regression.  Trunk shows "undefined" in the same situation.  Having said that, it is a bug :)

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

It's possible that this didn't regress by the hand of your bug (though I still have the feeling that the refactoring changed the times when this gets hit), but it certainly is a regression from a month or two ago.

Comment 3

[Wayne Mery (:wsmwk)]

just happen after my first entry into a newsgroup after having deleted panacea.dat, whose view *I think* was "unread" - uncertain. changed to all and all is well

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

This was glaringly obvious for a days after the initial landing, but shortly after that some kind of fix landed, and I don't think I've seen it since.  I suspect this wants to be closed as WORKSFORME, but Wayne can make that call.  Unless we have some reason to believe that this happens often, I don't think it would really block Thunderbird3, so minusing for now.  Feel free to make the case that that's wrong and renominate.

Comment 5

[Wayne Mery (:wsmwk)]

(In reply to comment #4)
> This was glaringly obvious for a days after the initial landing, but shortly
> after that some kind of fix landed, and I don't think I've seen it since.  

hopefully asuth or someone knows more ... I continue to find folders with view at 0.  But once changed then that folder is good.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

It would be nice to find exact steps to reproduce here; adding qawanted.  If this is going to happen for every Tb2 user who uses views, this probably wants to be renominated to block.

Comment 7

[Wayne Mery (:wsmwk)]

I have no idea :)  sorry to pass the buck

Comment 8

[Magnus Melin [:mkmelin]]

This was one of the more annoying bugs i found going from b2->b3 with a profile.

The STRs are quite easy:
 1) start with a build from say 2009-06-03
 2) set the view for a folder to Unread
 3) close
 4) start with a current build

Then observe - the view shows "0"

Regressed 2009-06-12 -> 2009-06-13

Comment 9

[David Ascher (:davida)]

sounds like it'll hit a lot of upgraders.  approving blocking.

Comment 10

[David :Bienvenu]

it's not just that the view label is set to 0, it doesn't display the unread messages view either, which is much more annoying than I understood it to be.

Comment 11

[David :Bienvenu]

Attachment: proposed fix

this fixes it for me - 2.0 sets "current-view" and "current-view-tag" to "0" for all and "1" for the unread view, so we need to check for both "0" and "1" when migrating views.

Asuth should probably look at this when he gets back to make sure, but this seems to work fine for me.

Comment 12

[Magnus Melin [:mkmelin]]

Comment on attachment 403282 [details] [diff] [review]
proposed fix

Looks to be working. Could use a code comment though! r=mkmelin

Comment 13

[David :Bienvenu]

I added a comment before pushing.