Closed Bug 497383 Opened 12 years ago Closed 12 years ago

"Always keep starred messages" disappears from all accounts after visiting deferred POP Disk Space settings

Categories

(Thunderbird :: Account Manager, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

I've noticed this while testing today's nightly after the checkin for
bug 326584, but tracked it down to bug 324147 as the source. That patch
removed the hidefor="" attribute in am-offline.xul, thus once hidden it
doesn't reappear when Disk Space/Synchronization&Storage of another account
is visited. Adding back the hidefor attribute to retention.applyToFlagged restores it.

Steps to reproduce:
1. Open Local Folders in Account Manager
2. Note that "keep starred messages" is present in Disk Space
3. Go to Disk Space of a deferred POP account, back to Local Folders
4. No "keep starred messages" is present now in Disk Space
Attached patch Proposed fixSplinter Review
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Attachment #382522 - Flags: superreview?(bienvenu)
Attachment #382522 - Flags: review?(mnyromyr)
Comment on attachment 382522 [details] [diff] [review]
Proposed fix

I'm canceling the review requests as the patch for bug 326584 had to be backed out. Thus, this may well be resolved within the scope of that patch, or based on the original bug 324147 code if a fix over there takes longer.
Attachment #382522 - Flags: superreview?(bienvenu)
Attachment #382522 - Flags: review?(mnyromyr)
(Bug 326584 comment #40)
> (From update of attachment 384081 [details] [diff] [review])
> Checked in: http://hg.mozilla.org/comm-central/rev/173f8884efed

The proposed change was included in that patch and has just been checked in.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.