497424 - Port Bug 452162 (Lessen the number of cases where a restart is required on application update) to SeaMonkey installer

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Frank Wein [:mcsmurf]]

Bug 452162 should be ported to the SeaMonkey installer as we also use MapiProxy.dll and mozMapi32.dll, this bug can affect SeaMonkey, too.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Same patch as in Bug 452162 except that I added a file exists check in SetAsDefaultAppGlobal for the DLLs as those might not exist if one uses a ZIP build.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 382605 [details] [diff] [review]
Patch

Sorry for the delay, it seems to me there are a couple of things missing:

- the port of the patch from bug 499958.
- changing mailnews/mapi/mapihook/src/Registry.cpp to use the correct dll name.

Most of the rest of the patch looks reasonable as a straight port.

Comment 4

[Frank Wein [:mcsmurf]]

Comment on attachment 382605 [details] [diff] [review]
Patch

This code does not need the changes from Bug 499958 as it does not call SetClientsMail. It also does not need to change the DLL name as the shell service code does not call RegisterServer anymore (the old code did, see CVS repository on mxr).

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 382605 [details] [diff] [review]
Patch

Thanks for the explaination.

I've not tested this, but this looks fine.

Please can you raise a bug on removing (Un)RegisterServer from the mapihook code as like you say it isn't used now.

Comment 6

[Frank Wein [:mcsmurf]]

Pushed to comm-central, http://hg.mozilla.org/comm-central/rev/d0d99968356c

Comment 7

[Frank Wein [:mcsmurf]]

Filed Bug 509185 on this.