499958 - When you right click and Send To 'Mail Recipient' it fails [ms windows] / Send Attachment

Status: VERIFIED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Andrew Harris]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.11) Gecko/2009060215 Firefox/3.0.11 (.NET CLR 3.5.30729)
Build Identifier: version 2.0.0.22 (20090605)

New update wipes the DLLPath setting in registry

HKLM\SOFTWARE\Clients\Mail\Mozilla Thunderbird

Should be C:\\Program Files\\Mozilla Thunderbird\\mozMapi32.dll

Have fixed mine and two others!

Reproducible: Always

Steps to Reproduce:
1.Right click on file
2.Select 'Send To'
3.Select 'Mail Recipent'
Actual Results:  
Nothing

Expected Results:  
Should open Thunderbird with attachment

Have fixed it with reg file below:-

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\Mozilla Thunderbird]
@="Mozilla Thunderbird"
"DLLPath"="C:\\Program Files\\Mozilla Thunderbird\\mozMapi32.dll"

Comment 1

[Andrew Harris]

Attachment: Windows Registry Fix

Windows Regitry Patch to re-enter DLL information to registry

Comment 3

[Frank Wein [:mcsmurf]]

Did you update via the internal update function or via downloading the new version from the Thunderbird website?

Comment 5

[Frank Wein [:mcsmurf]]

Ok, this bug happens when using the internal update function, the problem is http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mail/installer/windows/nsis/shared.nsh&rev=1.2.2.6&mark=40#40 (SetClientsMail) calls GetFullPathName on mozMapi32_InUse.dll. But mozMapi32_InUse.dll gets copied later in UpgradeMapiDLLs... (see line 53).

Comment 7

[Frank Wein [:mcsmurf]]

Attachment: Patch

Ok, multiple problems :|. See Comment 5 for the first problem and the other problem was/is the shellservice also using some old file name (so the workaround of setting another app as default mail client and then Thunderbird again will currently set mozMapi32.dll as DLLPath again, we don't want that!). The other occurrences of mozMapi32.dll in the code are obsolete or SeaMonkey only.

Comment 8

[Frank Wein [:mcsmurf]]

Comment on attachment 384697 [details] [diff] [review]
Patch

>+  // Set DLLPath again as SetClientsMail will fail if mozMapi32_InUse.dll does
>+  // not exist yet 

Make that "as GetFullPathName in SetClientsMail will return an empty path"

Comment 13

[Frank Wein [:mcsmurf]]

Attachment: Windows Registry Workaround

This is a better workaround, it will work if you installed Thunderbird with default settings and you use a English Windows version. Just save the file to disk and then execute it. If you prefer to apply the workaround manually, you have to set in the registry HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\Mozilla Thunderbird the DLLPath key to "C:\Program Files\Mozilla Thunderbird\mozMapi32_InUse.dll" (without the quotes).
Another workaround is to set another mail client as default mail client (for example Outlook Express) and then Thunderbird as default mail client again. But I would not recommend this as this might cause the same problems as in Bug 452162 again.

Comment 17

[Arthur Held]

NOTE: If you are running Windows Vista 64, this does not work. The path must be changed from \program files\  to \program files (x86)\

Comment 24

[Mark Banner (:standard8)]

Comment on attachment 384697 [details] [diff] [review]
Patch

This looks the right thing to do. I haven't tested it as I haven't got a build env. Therefore requesting that Robert looks at this as well.

ss: We should make sure we have a litmus test on 2.x series for this bug as well.

Comment 26

[Wayne Mery (:wsmwk)]

ludo, didn't find any litmus tests

fix summary

Comment 31

[Robert Strong (they/them - no direct email)]

Comment on attachment 384697 [details] [diff] [review]
Patch

This works but I think it would be cleaner to call ${UpgradeMapiDLLs} before ${SetClientsMail}. Any reason not to do so?

With that fixed or an answer as to why r=me

Comment 32

[Robert Strong (they/them - no direct email)]

I also recommend implementing what I mentioned in bug 452162 comment #148.

Comment 35

[duparchy]

After applying the proposed fix below, The default mail icon is greyed out in the Start Menu (Vista).

>[HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\Mozilla Thunderbird]
>@="Mozilla Thunderbird"
>"DLLPath"="C:\\Program Files\\Mozilla Thunderbird\\mozMapi32.dll"

Comment 39

[Brian Cupp]

I downloaded yesterdays nightly build of Shredder and this bug was not an issue for me any more.

Will there be a Thunderbird 2.0.0.23 or do we have to wait for Thunderbird 3 for this to be fixed?

Comment 43

[Samuel Sidler (old account; do not CC)]

(In reply to comment #39)
> Will there be a Thunderbird 2.0.0.23 or do we have to wait for Thunderbird 3
> for this to be fixed?

There will, indeed, be a Thunderbird 2.0.0.23 which we will fix this in.

Comment 45

[Brian Cupp]

(In reply to comment #43)
> There will, indeed, be a Thunderbird 2.0.0.23 which we will fix this in.

Is there a time frame for when this will be released?

Comment 48

[Frank Wein [:mcsmurf]]

Attachment: Better patch

Just call UpgradeMapiDLLs before SetClientsMail.

Comment 50

[Frank Wein [:mcsmurf]]

Comment on attachment 385369 [details] [diff] [review]
Better patch

This patch fixes a major regression in TB 2.0.0.22. Not really tested on trunk as the patch does not apply to trunk and testing this involves using the update function.

Comment 51

[Robert Strong (they/them - no direct email)]

(In reply to comment #50)
> (From update of attachment 385369 [details] [diff] [review])
> This patch fixes a major regression in TB 2.0.0.22. Not really tested on trunk
> as the patch does not apply to trunk and testing this involves using the update
> function.
I don't think this is a problem on trunk. Do you think it is?

Comment 52

[soleiljim]

I tried the executable patch from comment #13 and it did not fix the problem I listed in #48 Bug 500682.  Does this patch work with Vista 64?  If not can you create one?  I do know how to and do not want to manually alter my files.

Comment 53

[Frank Wein [:mcsmurf]]

Attachment: Windows Vista 64-bit version registry workaround

This one is for people using the 64-bit version of Windows Vista (also see Comment 17 on this).

Comment 54

[soleiljim]

Thanks Frank.  Your Windows Vista 64-bit version registry workaround solved both the right click send problem and the email photo from Picasa 3.

Comment 61

[William Cotter]

I found the "Better Patch" and ran it.  It cured my problem with my Endicia postage program not sending automatic email confirmations due to "Must install email client with MAPI access"

Comment 62

[Brian Cupp]

How do I install this patch?

Comment 63

[William Cotter]

Now that I recall, I installed the one listed under "Windows Registry Workaround" by clicking on the highlighted text.  It then downloaded to my computer and I double clicked on it to run it.  You may have to re-boot after installation.

Comment 71

[Brian Cupp]

How do I install the "Better Patch"?

Comment 72

[Jim Firpo]

The fix in comment 13 did the job wonderfully.  This is one of the few times that FAQs has really helped.

Comment 73

[Jim Firpo]

(In reply to comment #71)
> How do I install the "Better Patch"?


Try comment 13

Comment 74

[Joe Dipierro]

The solution in Comment 13 worked perfectly, and I had no trouble installing it. Thanks for the great work.

Comment 75

[Ludovic Hirlimann [:Usul]]

(In reply to comment #24)
 
> ss: We should make sure we have a litmus test on 2.x series for this bug as
> well.

https://litmus.mozilla.org/show_test.cgi?id=7786 is one for 2.x

It's cloned version for 3.x series.

Comment 77

[Steve]

The Windows Registry Fix seemed to work just fine.
Thank you very much.

Comment 78

[oldtinker]

I am running Vista 64 and have applied the registry fix. I still cannot get TB 2.0.0.22 to open from a Send To context menu pick or to email pictures from Picasa 3 where TB is designated as the default email application. Is there something else I can try?

Comment 79

[Arthur Held]

RE comment 78/Vista: See comment #17 - the patch was specific to 32 bit Windows and does not allow for the Vista64 path "/program files (x86)/" for non-64 bit programs. Therefore you have to edit the registry manually for Vista64.

Comment 80

[oldtinker]

I installed the registry patch located at https://bugzilla.mozilla.org/attachment.cgi?id=385439 which includes the path change required for Vista 64 and the Send To function still doesn't work.

Comment 82

[Richard Bunn]

I downloaded the file from comment #13 and invoked it, everything is back to wonderful. Thanks! Woo Hoo!

Richard Bunn

Comment 86

[rsx11m]

Comment on attachment 385369 [details] [diff] [review]
Better patch

Is there any specific reason that this patch hasn't received branch approval yet? It's pending for about a month now, and reports keep coming in...

Comment 87

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #86)
> (From update of attachment 385369 [details] [diff] [review])
> Is there any specific reason that this patch hasn't received branch approval
> yet? It's pending for about a month now, and reports keep coming in...

CC'ing dveditz...

Comment 88

[Samuel Sidler (old account; do not CC)]

Comment on attachment 385369 [details] [diff] [review]
Better patch

Approved for 1.8.1.23. a=ss

We intend to fix this in Thunderbird 2.0.0.23.

(This was on my list to approve, I've just been busy with some other things happening this week.)

Comment 90

[Frank Wein [:mcsmurf]]

Checking in mail/components/shell/nsMailWinIntegration.cpp;
/cvsroot/mozilla/mail/components/shell/nsMailWinIntegration.cpp,v  <--  nsMailWi
nIntegration.cpp
new revision: 1.2.2.5; previous revision: 1.2.2.4
done
Checking in mail/installer/windows/nsis/shared.nsh;
/cvsroot/mozilla/mail/installer/windows/nsis/shared.nsh,v  <--  shared.nsh
new revision: 1.2.2.7; previous revision: 1.2.2.6
done

Comment 91

[Eva S. Balogh]

Fantastic. It is fixed. Thanks whoever did it.

Comment 92

[Brian Cupp]

Where do I get the installer (Not the Registry Workaround) to fix this?

Comment 93

[Ludovic Hirlimann [:Usul]]

(In reply to comment #92)
> Where do I get the installer (Not the Registry Workaround) to fix this?

Next version of tb will have it.

Comment 96

[Al Billings [:abillings - ex-MoCo]]

Verified fixed in the nightly 2.0X build (Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.22pre) Gecko/2009080403 Thunderbird/2.0.0.22pre).

Comment 98

[David Reinstein]

Fixed!  Thanks.

Comment 99

[Brian Cupp]

When will 2.0.0.23 be released?

Comment 102

[rsx11m]

(In reply to comment #99)
> When will 2.0.0.23 be released?

It's currently not yet scheduled, watch https://wiki.mozilla.org/Releases

Comment 104

[stickman_mr]

Tried the 64-bit fix in Windows XP64 and no luck. Does it need a separate fix?

Comment 105

[stickman_mr]

To elucidate: checked in the  HKEY_LOCAL_MACHINE\SOFTWARE\Clients\Mail\ part of the registry using Registry Workshop (can't find a link to Windows Registry Editor Version 5.00) on my XP64 machine. There appear to be only folders for Hotmail and Outlook Express and nothing for Mozilla Thunderbird at all.

Can anyone help out please. I don't want to mess with my registry because I have no experience, but equally not being able to right-click and send files is ruining any practical possibility I have of escaping from MS email programs!

Comment 106

[Magnus Melin [:mkmelin]]

stickman_mr: commenting on closed bugs like this one is pointless. If you see the problem after you resinstall into another (empty) folder, file a new bug about it if you can't find one thats open already.