Closed
Bug 497723
Opened 12 years ago
Closed 12 years ago
[Mac] Alltabs dropdown lacks scroll arrows
Categories
(Toolkit :: Themes, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
Tracking | Status | |
---|---|---|
status1.9.1 | --- | .2-fixed |
People
(Reporter: u279076, Assigned: mstange)
References
Details
(Keywords: regression, verified1.9.1, Whiteboard: [mocotestday])
Attachments
(3 files)
80.54 KB,
image/png
|
Details | |
74.38 KB,
image/png
|
Details | |
2.97 KB,
patch
|
dao
:
review+
beltzner
:
approval1.9.1.2+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b99) Gecko/20090605 Firefox/3.5b99 STR: 1. Open a crap-tonne of tabs (100 is a safe bet) 2. Click the alltabs button 3. Place the mouse at the whitespace to the bottom of the dropdown 4. Place the mouse at the whitespace to the top of the dropdown RESULT: 1. Whitespace at top and bottom of the dropdown is considerably larger on Mac than Windows and Linux 2. Whitespace is lacking scroll arrows EXPECTED: Whitespace should contain a scroll arrow to indicate scrolling direction (as it does on Linux and Windows) Screenshots to follow.
Screenshot of Windows. Notice the small arrows at the top and bottom of the dropdown. Linux looks similar to this.
Updated•12 years ago
|
Flags: wanted1.9.1.x+
Flags: blocking1.9.1.1?
Regressed on May 31, 2009: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090530 Shiretoko/3.5pre -> Arrows appear. Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090531 Shiretoko/3.5pre -> Arrows do not appear.
Assignee | ||
Comment 6•12 years ago
|
||
Got it.
Assignee | ||
Comment 7•12 years ago
|
||
The autorepeatbuttons use list-style-image without turning off -moz-image-region, so they inherit the -moz-image-region value that the patch in bug 494659 set on the alltabs button. The Winstripe scrollbox.css file does this correctly, so I'm doing it the same way in the Pinstripe file. At some point these files should be reindented, though.
Attachment #385554 -
Flags: review?(dao)
Updated•12 years ago
|
Component: Tabbed Browser → Themes
Product: Firefox → Toolkit
QA Contact: tabbed.browser → themes
Version: 3.5 Branch → 1.9.1 Branch
Comment 8•12 years ago
|
||
Comment on attachment 385554 [details] [diff] [review] patch v1 Please don't maintain the weird whitespace formatting, just indent it as we always do.
Attachment #385554 -
Flags: review?(dao) → review+
Assignee | ||
Comment 9•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/fbf28b9e618d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Assignee | ||
Updated•12 years ago
|
Attachment #385554 -
Flags: approval1.9.1?
Assignee | ||
Comment 10•12 years ago
|
||
Comment on attachment 385554 [details] [diff] [review] patch v1 (I'd ask for approval1.9.1.1, but that flag doesn't exist yet.)
Assignee | ||
Updated•12 years ago
|
Attachment #385554 -
Flags: approval1.9.1? → approval1.9.1.1?
Comment 11•12 years ago
|
||
Not blocking 1.9.1.1, but we'll look at the patch later.
Flags: blocking1.9.1.1?
Comment 12•12 years ago
|
||
Comment on attachment 385554 [details] [diff] [review] patch v1 a1912=beltzner, please land on mozilla-1.9.1
Attachment #385554 -
Flags: approval1.9.1.1? → approval1.9.1.2+
Updated•12 years ago
|
status1.9.1:
--- → wanted
Flags: wanted1.9.1.x+
Assignee | ||
Comment 13•12 years ago
|
||
Dão, can you check this in for me? I really should be studying...
Keywords: checkin-needed
Comment 14•12 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/810cc5823c7c
Keywords: checkin-needed
Reporter | ||
Comment 15•12 years ago
|
||
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 Verified fixed 1.9.1.2
Status: RESOLVED → VERIFIED
Keywords: verified1.9.1
Reporter | ||
Comment 16•12 years ago
|
||
https://litmus.mozilla.org/show_test.cgi?id=7895 in-litmus+
Flags: in-litmus+
You need to log in
before you can comment on or make changes to this bug.
Description
•