49778 - remove the outOfDate (:out-of-date) pseudo-class from the build

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Hixie (not reading bugmail)]

There is some dead code in the style system that references an ':out-of-date'
pseudo-class, but as far as I can tell the only effect this code has is to
slow down the pseudo-class matching code.

This code was checked in during May 1998 by Peter Linss. It has not had any
major changes since then.

The following files are affected:
   /editor/ui/composer/content/EditorOverride.css
   /layout/html/document/src/html.css [I am fixing this file]
   /layout/html/style/public/nsCSSAtomList.h
   /layout/html/style/src/nsCSSParser.cpp
   /layout/html/style/src/nsCSSStyleSheet.cpp [1]

In addition, the following files seem to attempt to demo this pseudo-class:
   /htmlparser/tests/logparse/test1.bl
   /layout/html/tests/printer/general/test1.html
   /webshell/tests/viewer/samples/test1.html

[1]: In particular lines 3037 and 2737, which are called for almost every 
pseudo-class that we try to match...

Recommend nsbeta3+ as his seems rather low-risk.

Comment 1

[Hixie (not reading bugmail)]

Nominating for nsbeta3. This is a simple, low risk bug, and it should improve
performance a minute amount.

Comment 2

[Marc Attinasi]

Denying for beta3: This is not essential for shipping the product, and the 
benefits are pretty small overall. We could better use Pierre's skills on more 
serious bugs.

Comment 3

[Hixie (not reading bugmail)]

Taking QA per managerial policy.

Comment 4

[Hixie (not reading bugmail)]

I have a fix for this, but I can't easily make a diff for it until my fix for
bug 46916 is checked in, since they both affect files in content/html/style/src 
quite close to each other and thus the diffs make little sense...

Comment 5

[Hixie (not reading bugmail)]

Attachment: Patch: surgically removes all mention of the outOfDate link state...

Comment 6

[Hixie (not reading bugmail)]

Ok, there's the patch. I removed all mentions of outOfDate pseudos and outOfDate
link states, including a comment "// XXX how to tell if eLinkState_OutOfDate?".

This touches various areas:
   Style System: Pierre, could you look this over and see if it is worth
                 your moa= and r=?
       WebShell: Who should review the Webshell changes?
         Editor: Daniel, could you review the relevant changes to the editor
                 files and get moa= from the relevant person?

Marc, do you know if anyone else should take a look at this? If not, then I
guess I'll be asking for you to sr= my patch then, pleeeeease! :-)

Comment 7

[Marc Attinasi]

I don't think there is anyone else that needs to look at these changes - sr=attinasi

BTW: WebShell changes are trivial (just comment and unused enum), so I wouldn't
worry about it.

Comment 8

[Simon Fraser [no longer active]]

sr=sfraser for editor changes

Comment 9

[Hixie (not reading bugmail)]

Got moa=pierre by mail. I think that about covers it.

Comment 10

[Marc Attinasi]

Take it to the tree, man!

Comment 11

[Hixie (not reading bugmail)]

fixed

Comment 12

[Madhur Bhatia]

verified as per comments