Closed
Bug 497936
Opened 16 years ago
Closed 16 years ago
Don't show Collector promos in non-Firefox views
Categories
(addons.mozilla.org Graveyard :: Collector Extension, defect, P2)
addons.mozilla.org Graveyard
Collector Extension
Tracking
(Not tracked)
VERIFIED
FIXED
5.0.8
People
(Reporter: fligtar, Assigned: clouserw)
References
Details
Attachments
(1 file)
1.32 KB,
patch
|
fligtar
:
review+
|
Details | Diff | Splinter Review |
At least one person has installed the extension in Thunderbird (which it doesn't support) so we should hide the sidebar panels for the Collector from the directory and other collections pages if the user isn't browsing in /firefox.
We should also hide the line in the Add to Favorites lightbox that references the Collector when non-Firefox, but this might be harder to do with one l10n string, so that part's optional.
Reporter | ||
Updated•16 years ago
|
Priority: -- → P2
Target Milestone: --- → 5.0.8
Assignee | ||
Comment 2•16 years ago
|
||
This removes the sidebars from the faq and features pages as well as the collector directory sidebar and collection detail pages. It doesn't remove it from the collector page itself (/pages/collector) since if you go there it seems like you'd like to see it. r? to see if you want anything changed
Assignee: nobody → clouserw
Attachment #389968 -
Flags: review?(fligtar)
Reporter | ||
Comment 3•16 years ago
|
||
Comment on attachment 389968 [details] [diff] [review]
check for firefox
Looks good!
Attachment #389968 -
Flags: review?(fligtar) → review+
Assignee | ||
Comment 4•16 years ago
|
||
thanks, r30273
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 5•16 years ago
|
||
Verified FIXED on:
https://preview.addons.mozilla.org/en-US/thunderbird/collections/editors_picks
https://preview.addons.mozilla.org/en-US/thunderbird/pages/collector_faq
https://preview.addons.mozilla.org/en-US/thunderbird/pages/collector_features
https://preview.addons.mozilla.org/en-US/seamonkey/collections/editors_picks
https://preview.addons.mozilla.org/en-US/seamonkey/pages/collector_faq
https://preview.addons.mozilla.org/en-US/seamonkey/pages/collector_features
https://preview.addons.mozilla.org/en-US/sunbird/collections/editors_picks
https://preview.addons.mozilla.org/en-US/sunbird/pages/collector_faq
https://preview.addons.mozilla.org/en-US/sunbird/pages/collector_features
Status: RESOLVED → VERIFIED
Reporter | ||
Updated•15 years ago
|
Component: Collections → Collector Extension
Version: 3.2 → unspecified
Updated•15 years ago
|
QA Contact: collections → collector-extension
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•