498366 - When installing Growl, it should work without having to restart the application

Status: RESOLVED WONTFIX

(Toolkit :: UI Widgets, defect)

Description

[Florian Quèze [:florian]]

Attachment: Patch v1

Currently, Growl is registred after the final-ui-startup notification. If it is installed on the system after the XUL application started, it won't be usable until a restart of the application.

The attached patch changes the code to register with Growl after final-ui-startup if Growl is installed, or at the first ShowAlertNotification call after the installation of Growl.

Note: Without the patch, debug builds crash at the first ShowAlertNotification call after the installation of Growl on this line because mDeletage is NULL:
  NS_ASSERTION(mDelegate->delegate == [GrowlApplicationBridge growlDelegate],

Comment 1

[Asaf Romano (gone)]

What's the reason not to launch growl only in  ShowAlertNotification?

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch v2

(In reply to comment #1)
> What's the reason not to launch growl only in  ShowAlertNotification?

I didn't want to change when the before-growl-registration notification was sent in the common case of Growl already installed before the XUL application starting. Looking at it again, I'm not sure it made sense...

With this version of the patch, I'm not sure the Init method is still useful. I tend to think it's better to fail and produce a JS error on the getService call rather than on the showAlertNotification call, but I guess that's debatable.

It would also be nice to add there a clear error message reported to the error console, in addition of the NS_ERROR_SERVICE_NOT_AVAILABLE result code. That's probably covered by bug 382715 though.

Comment 3

[Shawn Wilsher :sdwilsh]

This breaks the user experience that mac users would expect.  All applications that use Growl register at application startup.  This is especially obvious the first time an application runs because growl will notify the user that the application has registered with Growl.

How do other applications on the mac (like Adium) handle the case of Growl being installed after the application is running?

Comment 4

[Asaf Romano (gone)]

Comment on attachment 383358 [details] [diff] [review]
Patch v2

I don't use growl much, so someone else should figure out what's the right UE. Then, please ask for review again.

Comment 5

[Florian Quèze [:florian]]

Bug 782211 removed growl support.