498415 - "N" for next message jumps to next folder, but does not open first unread message there when mailnews.nav_crosses_folders 0 is set

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Bill Burns]

User-Agent:       Opera/9.80 (Windows NT 5.1; U; en) Presto/2.2.15 Version/10.00
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090615 Shredder/3.0b3pre

When all messages in a folder have been read, "N" for next unread message used to jump to the next folder and open the first unread message there.  Now it jumps to the folder and displays the message headers, but the first unread message is not opened unless "N" is pressed again.

Reproducible: Always

Steps to Reproduce:
1.Create two folders with unread messages
2.Read all messages in the first folder
3.Use "N" to jump to next folder.
Actual Results:  
Folder message headers are displayed, but message body pane remains blank until "N" is pressed again.

Expected Results:  
First message in next folder should have been opened.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

asuth, bienvenu, was the behaviour meant to be changed in this way? (i.e. to display the folder message summaries instead of the next unread message by pressing "N")

Comment 2

[David :Bienvenu]

No, the intent was that when next unread made us go to a different folder, we would still expand the thread w/ new messages - I believe I had this working, but it might have regressed.

Comment 3

[Richard Marti (:Paenglab)]

This behaviour was introduced with bug 474701. I suppose this Bug should be dependent to bug 497199.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

I can't reproduce this in a current nightly build on Mac.  Can anyone else?

Comment 5

[Thomas Stache]

I can, every time (now on Windows). It just opens the folder, but doesn't select an unread message. A 2nd press will though...

Offline IMAP server (gmx.net).

Comment 6

[Thomas Stache]

(In reply to comment #5)
> I can, every time (now on Windows). It just opens the folder, but doesn't
> select an unread message. A 2nd press will though...
> 
> Offline IMAP server (gmx.net).

Just to double-check I confirmed the behavior in safe-mode. I only have Lightning, NTT and ViewAbout installed anyway...

Comment 7

[Alexander L. Slovesnik]

(In reply to comment #4)
> I can't reproduce this in a current nightly build on Mac.  Can anyone else?
I can reproduce it on Linux nightly build (this bug also presents in safe mode)

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

I can't reproduce this on Windows either; I suspect there needs to be some particular preference or setting in effect to trigger it.

Do you guys see it in a clean profile?

Comment 9

[Thomas Stache]

What's your value for "mailnews.nav_crosses_folders"? I have it set not to prompt, i.e. "0".

Comment 10

[Thomas Stache]

(In reply to comment #8, comment #9)
I really should have checked this right away, but using the pref's default value of "1" the next unread message is selected and displayed after the prompt to change the folder.

Comment 11

[Bill Burns]

I confirm this behaviour on WinXP. I have this set to "0"; when I change it to "1" the next unread message is selected and displayed after the prompt
to change the folder.  Changing it back to "0" restores the problem I reported.

Comment 12

[Magnus Melin [:mkmelin]]

Yeah I see that. Trivial fix coming up.

Comment 13

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

No, no tests, yet ;)

Comment 14

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 388743 [details] [diff] [review]
proposed fix

If you could change the code so that the "gFolderDisplay.pushNavigation(...); SelectFolder" block only happens once, that would be preferable.  (I would lose the switch, and add an if nextMode == 0 case that does the prompt and returns out of the function if they don't confirm.)

That way it's the same logic and although I would still love a unit test, arguably the non-default case will not be any more prone to breakage than the default case.

Comment 15

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2 (for final checkin)

Carrying fwd r=asuth

Comment 16

[Dave Meyer]

FYI, I'm still seeing this with 3.0b3

Comment 17

[Magnus Melin [:mkmelin]]

changeset:   3137:3338453a6e27
http://hg.mozilla.org/comm-central/rev/3338453a6e27

->FIXED

Comment 18

[Bill Burns]

Confirmed as fixed, but the focus in the message header pane does not jump to the selected message until N is pressed or the current message is deleted.

Comment 20

[MrC]

Unfortunately, this problem continues, but I've been able to more readily reproduce it.

By selecting the first item in an RSS folder, and then shift selecting the remainder of items, and hitting the Delete key, the Space key will not then advance to the next RSS folder with items.

There may be some relation to the number of items that were selected - I was able to repeat when the number of items fit within the size of the list window (i.e. scrolling not required).  I was able to repeat this time and again on various RSS folders.

Can somebody reopen this?

Comment 21

[MrC]

Reproducing this is even easier than I wrote above.  Simply select all messages, hit the Delete key, and try to use Space to advance to the next group.  Fails constantly.

Comment 22

[Magnus Melin [:mkmelin]]

Seems WFM for me, but either way, that would be another bug, so please file one if you still see it.

Comment 23

[MrC]

The regression persists, and bug 509393 still exists.