498465 - The reply-list button needs an icon.

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Blake Winton (:bwinton) (:☕️)]

Attachment: The current "Reply to List" button.

As per https://bugzilla.mozilla.org/show_bug.cgi?id=45715#c213, 
it would be nice to get a reply-list icon made instead of reusing the reply-all icon.

Thanks,
Blake.

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: reply-to-list for gnomestripe

Winstripe and Pinstripe coming up.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

I like it.

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

The reply list icon is going to land in the new toolbar so making this depend on that one.

Comment 4

[Blake Winton (:bwinton) (:☕️)]

What ever happened to this?

I just tried it on TB3 Beta 3 OS X, and it seemed to be using the Reply-All icon…

Thanks,
Blake.

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

I'm pretty sure that Windows and Linux got the new icon when the new toolbar images landed but we're still missing a Mac version right now.

Comment 6

[Andreas Nilsson (:andreasn)]

Attachment: patch for pinstripe

Comment 7

[Andreas Nilsson (:andreasn)]

the pinstripe patch also include a new icon for Compact that matches the one in the Activity Manager.

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 394836 [details] [diff] [review]
patch for pinstripe

looks good to me

Comment 9

[Andreas Nilsson (:andreasn)]

Attachment: updated patch

updated pinstripe patch after discussion on IRC. Puts reply-to-list after the other two reply-to actions and before the forward icon. This is what we do on qute and gnomestripe as well

Comment 10

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 395022 [details] [diff] [review]
updated patch

>  #button-replylist:hover:active {
> -  -moz-image-region: rect(32px 160px 64px 128px);
> -}
> +  -moz-image-region: rect(32px 192px 64px 160px);
> +} 
There's a trailing space at the end of this line.

+#button-goforward:hover:active {
+  -moz-image-region: rect(32px 544px 64px 512px);
+} 
+
+#button-goforward[disabled] {
+  -moz-image-region: rect(64px 544px 96px 512px) !important;
+} 

Ditto these two, and a few others throughout the file.

r=me with the trailings spaces fixed.

One thing I did notice in my testing, but I don't think it's due to your patch, was that the icons in the "Write" dropdown seem off a little.  Look to the left of "Message" in the screenshot at http://img89.imageshack.us/img89/4066/picture4j.png to see what I'm talking about.

Finally, I'm not a module owner or anything, so you should probably get someone else to review this as well before you mark it as checkin-needed.  philor or mkmelin seem like reasonable choices.

Thanks,
Blake.

Comment 11

[Andreas Nilsson (:andreasn)]

Attachment: pinstripe patch with whitespaces removed

Comment 12

[Phil Ringnalda (:philor)]

Comment on attachment 395528 [details] [diff] [review]
pinstripe patch with whitespaces removed

r=me, except for the the 288x in
>+  -moz-image-region: rect(24px 312px 48px 288x);
which I fixed before pushing.

Comment 13

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/9a8765dd63cc