Closed Bug 498509 Opened 11 years ago Closed 11 years ago

Produce debuggable optimized builds for Mozilla on MacOSX

Categories

(NSS :: Build, defect, P1, critical)

All
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.12.4

People

(Reporter: nelson, Assigned: glenbeasley)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

NSS is now able to build special builds that are optimized but also have debugging symbols.  This is presently enabled by setting the environment 
variable MOZ_DEBUG_SYMBOLS to a non-empty string.  But presently this 
only works on Windows, and then only when built with MSVC.  

This bug requests that it also be made to work with MacOSX builds.

The first step will be to determine what changes are needed to compiler 
and linker commands to do this.  Maybe we can get clues by studying 
Firefox build logs.
Blocks: 498511
Blocks: 468701
Assignee: nobody → glen.beasley
No longer blocks: 498511
Priority: -- → P1
Target Milestone: 3.12.4 → 3.12.5
It's critical that we be able to debug cores and stack traces from Macs.
Severity: enhancement → critical
Blocks: 505223
Status: NEW → ASSIGNED
We do this in Firefox simply by adding CFLAGS/CXXFLAGS="-gdwarf-2 -gfull"
Please treat this bug as urgent and with high priority.  

Crashes in NSS code are found in Mozilla's list of most frequent crashes,
and many of them are undiagnosed and unresolved because of this bug. 
Lack of resolution to these is the single biggest hindrance to Mozilla 
taking newer versions of NSS 3.12.x.  That is why I have marked these bugs 
as P1 for 3.12.5.
Depends on: 506796
Tested patch for 32 and 64 builds.
Attachment #390954 - Flags: review?(nelson)
Comment on attachment 390954 [details] [diff] [review]
create debuggable optimize builds if MOZ_DEBUG_SYMBOLS is set

Glen, does it work to add the flags to the OS_CFLAGS variable instead
(after line 108)?
Glen, I'd prefer if the flags would be added to one of the many make 
variables that exist for the purpose of holding flags for CC, such as
OS_CFLAGS.
Comment on attachment 390954 [details] [diff] [review]
create debuggable optimize builds if MOZ_DEBUG_SYMBOLS is set

thanks nelson/wanteh, I am in the process of testing the next patch.
Attachment #390954 - Flags: review?(nelson)
This patch follows the same approved functionality of bug 498511 which  Produced debuggable optimized NSS builds for Mozilla on Linux.
Attachment #390954 - Attachment is obsolete: true
Attachment #391671 - Flags: review?(nelson)
Comment on attachment 391671 [details] [diff] [review]
if BUILD_OPT and MOZ_DEBUG_SYMBOLS are set create debuggable optimize builds

r=nelson
Attachment #391671 - Flags: review?(nelson) → review+
Checking in Darwin.mk;
/cvsroot/mozilla/security/coreconf/Darwin.mk,v  <--  Darwin.mk
new revision: 1.22; previous revision: 1.21
done
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: 3.12.5 → 3.12.4
You need to log in before you can comment on or make changes to this bug.