498509 - Produce debuggable optimized builds for Mozilla on MacOSX

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[Nelson Bolyard (seldom reads bugmail)]

NSS is now able to build special builds that are optimized but also have debugging symbols.  This is presently enabled by setting the environment 
variable MOZ_DEBUG_SYMBOLS to a non-empty string.  But presently this 
only works on Windows, and then only when built with MSVC.  

This bug requests that it also be made to work with MacOSX builds.

The first step will be to determine what changes are needed to compiler 
and linker commands to do this.  Maybe we can get clues by studying 
Firefox build logs.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

It's critical that we be able to debug cores and stack traces from Macs.

Comment 2

[(not currently active) Ted Mielczarek]

We do this in Firefox simply by adding CFLAGS/CXXFLAGS="-gdwarf-2 -gfull"

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Please treat this bug as urgent and with high priority.  

Crashes in NSS code are found in Mozilla's list of most frequent crashes,
and many of them are undiagnosed and unresolved because of this bug. 
Lack of resolution to these is the single biggest hindrance to Mozilla 
taking newer versions of NSS 3.12.x.  That is why I have marked these bugs 
as P1 for 3.12.5.

Comment 4

[glen beasley]

Attachment: create debuggable optimize builds if MOZ_DEBUG_SYMBOLS is set

Tested patch for 32 and 64 builds.

Comment 5

[Wan-Teh Chang]

Comment on attachment 390954 [details] [diff] [review]
create debuggable optimize builds if MOZ_DEBUG_SYMBOLS is set

Glen, does it work to add the flags to the OS_CFLAGS variable instead
(after line 108)?

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Glen, I'd prefer if the flags would be added to one of the many make 
variables that exist for the purpose of holding flags for CC, such as
OS_CFLAGS.

Comment 7

[glen beasley]

Comment on attachment 390954 [details] [diff] [review]
create debuggable optimize builds if MOZ_DEBUG_SYMBOLS is set

thanks nelson/wanteh, I am in the process of testing the next patch.

Comment 8

[glen beasley]

Attachment: if BUILD_OPT and MOZ_DEBUG_SYMBOLS are set create debuggable optimize builds

This patch follows the same approved functionality of bug 498511 which  Produced debuggable optimized NSS builds for Mozilla on Linux.

Comment 9

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 391671 [details] [diff] [review]
if BUILD_OPT and MOZ_DEBUG_SYMBOLS are set create debuggable optimize builds

r=nelson

Comment 10

[glen beasley]

Checking in Darwin.mk;
/cvsroot/mozilla/security/coreconf/Darwin.mk,v  <--  Darwin.mk
new revision: 1.22; previous revision: 1.21
done