Improve identity display on security tab

RESOLVED FIXED in seamonkey2.0b2

Status

SeaMonkey
Page Info
--
enhancement
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: Robert Kaiser, Assigned: Robert Kaiser)

Tracking

({polish})

Trunk
seamonkey2.0b2
polish
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Now that bug 465504 has given more access points that link to the page info security tab, we should make that reflect identity better.
We should make up for not having the "Larry popup" of Firefox by providing that info in the tab, including the icon.
(Assignee)

Updated

8 years ago
Severity: normal → enhancement
(Assignee)

Updated

8 years ago
Keywords: polish
Whiteboard: [good first bug]
(Assignee)

Comment 1

8 years ago
Created attachment 396754 [details] [diff] [review]
provide identity icon in security tab

Here's a patch for displaying the icon in the security tab to give people a bit more of a visual clue.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #396754 - Flags: superreview?(neil)
Attachment #396754 - Flags: review?(neil)

Comment 2

8 years ago
Is there a yellow version as well? I could use that for the modern certError.css which is currently using chrome://global/skin/icons/alert-security.gif
(Assignee)

Comment 3

8 years ago
I just copied the Firefox .png so if they have a different version anywhere, it's in a different image.

Comment 4

8 years ago
Found it in sslWarning.png. By the way the classic mac indentity.png should be the pinstripe version shouldn't it? CC Stefan.

Updated

8 years ago
Attachment #396754 - Flags: superreview?(neil)
Attachment #396754 - Flags: superreview+
Attachment #396754 - Flags: review?(neil)
Attachment #396754 - Flags: review+

Comment 5

8 years ago
Comment on attachment 396754 [details] [diff] [review]
provide identity icon in security tab

>-          </grid>
>+          <hbox>
>+            <image id="identity-icon"/>
>+            <grid flex="1">
diff -w would have been nice ;-)

>+      document.getElementById("identity-icon").className = "verifiedIdentity";
Nit: put this value into a variable ("verification" perhaps?) and set the class name along with the text labels below.

>+  height: 64px;
>+  width: 64px;
Nit: width before height.

>+  padding: 0;
Nit: unnecessary.
(Assignee)

Comment 6

8 years ago
Pushed as http://hg.mozilla.org/comm-central/rev/6308cada419a
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b2
(Assignee)

Updated

8 years ago
Whiteboard: [good first bug]

Updated

6 years ago
Depends on: 675462
You need to log in before you can comment on or make changes to this bug.