Last Comment Bug 498618 - Improve identity display on security tab
: Improve identity display on security tab
: polish
Product: SeaMonkey
Classification: Client Software
Component: Page Info (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: seamonkey2.0b2
Assigned To: Robert Kaiser
Depends on: 465504 675462
  Show dependency treegraph
Reported: 2009-06-16 06:37 PDT by Robert Kaiser
Modified: 2011-07-30 15:00 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

provide identity icon in security tab (37.27 KB, patch)
2009-08-26 10:35 PDT, Robert Kaiser
neil: review+
neil: superreview+
Details | Diff | Splinter Review

Description Robert Kaiser 2009-06-16 06:37:49 PDT
Now that bug 465504 has given more access points that link to the page info security tab, we should make that reflect identity better.
We should make up for not having the "Larry popup" of Firefox by providing that info in the tab, including the icon.
Comment 1 Robert Kaiser 2009-08-26 10:35:36 PDT
Created attachment 396754 [details] [diff] [review]
provide identity icon in security tab

Here's a patch for displaying the icon in the security tab to give people a bit more of a visual clue.
Comment 2 Philip Chee 2009-08-26 11:09:21 PDT
Is there a yellow version as well? I could use that for the modern certError.css which is currently using chrome://global/skin/icons/alert-security.gif
Comment 3 Robert Kaiser 2009-08-26 13:55:14 PDT
I just copied the Firefox .png so if they have a different version anywhere, it's in a different image.
Comment 4 Philip Chee 2009-08-26 18:26:23 PDT
Found it in sslWarning.png. By the way the classic mac indentity.png should be the pinstripe version shouldn't it? CC Stefan.
Comment 5 2009-09-01 03:06:32 PDT
Comment on attachment 396754 [details] [diff] [review]
provide identity icon in security tab

>-          </grid>
>+          <hbox>
>+            <image id="identity-icon"/>
>+            <grid flex="1">
diff -w would have been nice ;-)

>+      document.getElementById("identity-icon").className = "verifiedIdentity";
Nit: put this value into a variable ("verification" perhaps?) and set the class name along with the text labels below.

>+  height: 64px;
>+  width: 64px;
Nit: width before height.

>+  padding: 0;
Nit: unnecessary.
Comment 6 Robert Kaiser 2009-09-01 11:14:10 PDT
Pushed as

Note You need to log in before you can comment on or make changes to this bug.