498618 - Improve identity display on security tab

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, enhancement)

Description

[Robert Kaiser]

Now that bug 465504 has given more access points that link to the page info security tab, we should make that reflect identity better.
We should make up for not having the "Larry popup" of Firefox by providing that info in the tab, including the icon.

Comment 1

[Robert Kaiser]

Attachment: provide identity icon in security tab

Here's a patch for displaying the icon in the security tab to give people a bit more of a visual clue.

Comment 2

[Philip Chee]

Is there a yellow version as well? I could use that for the modern certError.css which is currently using chrome://global/skin/icons/alert-security.gif

Comment 3

[Robert Kaiser]

I just copied the Firefox .png so if they have a different version anywhere, it's in a different image.

Comment 4

[Philip Chee]

Found it in sslWarning.png. By the way the classic mac indentity.png should be the pinstripe version shouldn't it? CC Stefan.

Comment 5

[[e-mail]]

Comment on attachment 396754 [details] [diff] [review]
provide identity icon in security tab

>-          </grid>
>+          <hbox>
>+            <image id="identity-icon"/>
>+            <grid flex="1">
diff -w would have been nice ;-)

>+      document.getElementById("identity-icon").className = "verifiedIdentity";
Nit: put this value into a variable ("verification" perhaps?) and set the class name along with the text labels below.

>+  height: 64px;
>+  width: 64px;
Nit: width before height.

>+  padding: 0;
Nit: unnecessary.

Comment 6

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/rev/6308cada419a