675462 - [Mac default] No identity icon in pageInfo window's security tab

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

Bug 498618 added a identity icon in the security tab. However, the mac version of pageInfo.css was never patched. IIRC, I talked to Kairo about it, but never filed a bug. Now it's the right time to file a bug :-)

The mac version of pageInfo.css sets width/height for the window (yeah, I know--very evil) and I doubt the icon fits atm. I should probably remove the width/height hacks, but I don't want the window width/height change too much, though.

Comment 1

[Stefan [:stefanh]]

Attachment: Add identity icon

OK, so I believe we need to keep the window dimension hack for now. Turns out that 100ch is 698px wide and 38em translates to 455px in height. I think 600 in width (which is what I changed it to in the css to get more space) and *at least* 500 in height would probably be ok (it's 530 now).

I'd naturally prefer if we can defer the window dimension discussion to another bug (iirc I asked about this when I re-did the theme, but I was told that the existing dimensions was perfect on win/nix).

JFTR: The identity icon in this patch is ripped from pinstripe (differs from winstripe)

Comment 2

[Stefan [:stefanh]]

Comment on attachment 549690 [details] [diff] [review]
Add identity icon

Seems that I forgot to set the review flag, please see comment #1.

Comment 3

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/eb1f0b511bda