498841 - gURLBar.timeout shouldn't be set in BrowserStartup

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Dão Gottwald [:dao]]

browserStartup is the wrong place for this, as the urlbar doesn't necessarily exist on startup.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Simon Bünzli]

Comment on attachment 383654 [details] [diff] [review]
patch

While you're touching this code:

>+      document.documentElement.getAttribute("chromehidden").indexOf("toolbar") != -1) {

|toolbar.visible| would be so much easier to read...

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> >+      document.documentElement.getAttribute("chromehidden").indexOf("toolbar") != -1) {
> 
> |toolbar.visible| would be so much easier to read...

IIRC that's not the same test, though I don't recall the distinction.

Comment 4

[Dão Gottwald [:dao]]

I don't think there's a difference... I recall researching this for bug 470051. A quick search now leads to this:
http://mxr.mozilla.org/mozilla-central/source/dom/base/nsBarProps.cpp#165
http://mxr.mozilla.org/mozilla-central/source/xpfe/appshell/src/nsXULWindow.cpp#2093

I won't change it in this bug, though.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/4f76b5fce530