Disable Archive button on summary collapsed threads in archive folder



9 years ago
3 years ago


(Reporter: Aureliano, Unassigned)


(Blocks: 1 bug)

Windows XP
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)



(1 attachment)



9 years ago
In archive folder archive button should be disabled (because cannot archive mail which are alredy archived).

Click on the button in this situation not has effect: trivial issue.


9 years ago
Severity: normal → trivial
Ever confirmed: true

Comment 1

9 years ago
it used to be disabled, and then people complained when they changed the archive granularity, and couldn't re-archive...I suppose we could check if clicking archive would do anything before deciding to enable the button, though I think we'd want to punt in the case of a large multi-selection...
I think that's (roughly) the story for the menuitem, not the button in the message envelope, which we don't show for a single message but do show for a collapsed thread.
Summary: Archive button on summary collapsed threads in archive folder → Disable Archive button on summary collapsed threads in archive folder


8 years ago
Depends on: 542998

Comment 3

8 years ago
I think I may have regressed this in bug 542998. One solution (which I'll happily work on since it's my fault) would be to just enable cmd_archive when you have selected messages in the archive folder but that folder doesn't match whatever your current archive scheme is.

Comment 4

7 years ago
Created attachment 525333 [details] [diff] [review]
Enable archiving even in the archive folder [checked in]

This does the opposite of comment 0, but fixes the use case in comment 1, which is probably a net gain. Having a smarter solution in place would probably be nice, but at the very least, I want to make sure I don't regress this behavior for 3.3. If you think tests are necessary, let me know and I'll add some.
Attachment #525333 - Flags: review?(bienvenu)


7 years ago
Attachment #525333 - Flags: review?(bienvenu) → review+

Comment 5

7 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/8bbf54deea6b

Note that this bug isn't fixed yet, since that commit just fixed a regression from the behavior in comment 1. We should probably keep this open to make canArchiveSelectedMessages smarter one day.


7 years ago
Attachment #525333 - Attachment description: Enable archiving even in the archive folder → Enable archiving even in the archive folder [checked in]


7 years ago
No longer blocks: 360488

Comment 6

6 years ago
If you have the archive settings such that it keeps your folder structure within the archive, and then you accidentally re-archive a message, it totally destroys the folder structure. In other words, the messages are moved recursively into new archive folders within the current archive folders. This is quite problematic for me. The archive button should either be disabled within the archive folder, or something should be done to prevent recursive archiving folder creation.
You need to log in before you can comment on or make changes to this bug.