499270 - AIX Compilation error for 3.6a1pre source "../../../../dist/include/oggz/oggz_off_t_generated.h", line 65.9: 1506-166 (S) Definition of function loff_t requires parentheses.

Status: VERIFIED DUPLICATE of bug 576883

(Core :: Audio/Video, defect)

Description

[Shailen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.11) Gecko/2009060215 Firefox/3.0.11
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.11) Gecko/2009060215 Firefox/3.0.11

While compiling Mozilla Firefox source for 3.6a1pre, getting
the below error.

 /home/guest/sb/mercurial/src/media/liboggplay/src/liboggplay/
oggplay.c
"../../../../dist/include/oggz/oggz_off_t_generated.h", line 65.9:
1506-166 (S) Definition of function loff_t requires parentheses.
"../../../../dist/include/oggz/oggz_off_t_generated.h", line 65.16:
1506-276 (S) Syntax error: possible missing '{'?
"../../../../dist/include/oggz/oggz_comments.h", line 97.3: 1506-273
(E) Missing type in declaration of OggzComment.
"../../../../dist/include/oggz/oggz_comments.h", line 140.7: 1506-166
(S) Definition of function OggzComment requires parentheses.
"../../../../dist/include/oggz/oggz_comments.h", line 140.19: 1506-276
(S) Syntax error: possible missing '{'?
"../../../../dist/include/oggplay/oggplay_reader.h", line 64.3:
1506-273 (E) Missing type in declaration of OggPlayReader.
"../../../../dist/include/oggplay/oggplay_reader.h", line 73.1:
1506-166 (S) Definition of function OggPlayReader requires
parentheses.
"../../../../dist/include/oggplay/oggplay_reader.h", line 73.15:
1506-276 (S) Syntax error: possible missing '{'?
"../../../../dist/include/oggplay/oggplay_callback_info.h", line 46.3:
1506-273 (E) Missing type in declaration of OggPlayVideoData.
"../../../../dist/include/oggplay/oggplay_callback_info.h", line
64.52: 1506-277 (S) Syntax error: possible missing ')' or ','?
"../../../../dist/include/oggplay/oggplay_callback_info.h", line 64.1:
1506-282 (S) The type of the parameters must be specified in a
prototype.
"../../../../dist/include/oggplay/oggplay_callback_info.h", line
66.57: 1506-277 (S) Syntax error: possible missing ')' or ','?
"../../../../dist/include/oggplay/oggplay_callback_info.h", line 66.1:
1506-282 (S) The type of the parameters must be specified in a
prototype.
"../../../../dist/include/oggplay/oggplay_callback_info.h", line
68.56: 1506-277 (S) Syntax error: possible missing ')' or ','?
"../../../../dist/include/oggplay/oggplay_callback_info.h", line 68.1:
1506-282 (S) The type of the parameters must be specified in a
prototype.
"../../../../dist/include/oggplay/oggplay_callback_info.h", line
70.55: 1506-277 (S) Syntax error: possible missing ')' or ','?
"../../../../dist/include/oggplay/oggplay_callback_info.h", line 70.1:
1506-282 (S) The type of the parameters must be specified in a
prototype.
"../../../../dist/include/oggplay/oggplay_callback_info.h", line 75.1:
1506-166 (S) Definition of function OggPlayVideoData requires
parentheses.
"../../../../dist/include/oggplay/oggplay_callback_info.h", line
75.18: 1506-276 (S) Syntax error: possible missing '{'?
"../../../../dist/include/oggplay/oggplay_seek.h", line 43.22:
1506-277 (S) Syntax error: possible missing ')' or ','?
"../../../../dist/include/oggplay/oggplay_seek.h", line 43.1: 1506-282
(S) The type of the parameters must be specified in a prototype.
"../../../../dist/include/oggplay/oggplay_seek.h", line 49.34:
1506-277 (S) Syntax error: possible missing ')' or ','?
"../../../../dist/include/oggplay/oggplay_seek.h", line 49.1: 1506-282
(S) The type of the parameters must be specified in a prototype.
"../../../../dist/include/oggplay/oggplay.h", line 70.1: 1506-166 (S)
Definition of function OggPlay requires parentheses.
"../../../../dist/include/theora/theora.h", line 169.3: 1506-273 (E)
Missing type in declaration of yuv_buffer.
"../../../../dist/include/theora/theora.h", line 472.49: 1506-046 (S)
Syntax error.
"../../../../dist/include/theora/theora.h", line 599.50: 1506-046 (S)
Syntax error.
"/home/guest/sb/mercurial/src/media/liboggplay/src/liboggplay/
oggplay_private.h", line 90.3: 1506-046 (S) Syntax error.
gmake[1]: *** [oggplay.o] Error 1 

Reproducible: Always

Steps to Reproduce:
1. Build Mozilla Firefox 3.6a1pre build on AIX with Gnome RPMS of 64 bit
version.

2.
3.
Actual Results:  
Build fails with the above error.


Expected Results:  
No build failure

Comment 1

[Shailen]

Attachment: Patch V 2

The patch resolves this compilation error on AIX

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 384071 [details] [diff] [review]
Patch V 2

Actually, you'll need to package this as a patch to upstream liboggz. See how the other patches are done in README.mozilla.

Comment 3

[Conrad Parker]

I've received this patch from Shailen, but it can't apply to upstream liboggz as
the file oggz_off_t_generated.h is different for Mozilla. (liboggz upstream also has a file of the same name, but with contents generated by GNU autoconf).

Alternatively it could be done as a patch to liboggz/include/oggz_off_t.h upstream, checking for #ifdef MOZILLA or something.

Comment 4

[Shailen]

Hi   Robert O'Callahan,

   Can you please advise which approach we need to take  ?

Thanks,
Shialendra

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Sorry. Chris Double will advise you :-)

Comment 6

[Shailen]

Chris Double :

    Can you please advise ?


Thanks,
Shailendra

Comment 7

[cajbir (:cajbir)]

Follow the approach Conrad said in comment 4. Create a local patch that makes the change (follow the example of the patches in media/liboggz already). Add me as a reviewer, and I'll make sure it's ok.

Comment 8

[Shailen]

Attachment: Local patch

Created a local patch as suggested by Chris.

Thanks,
Shailendra

Comment 9

[cajbir (:cajbir)]

Comment on attachment 385943 [details] [diff] [review]
Local patch

The change is fine but before we can commit it you'll need to include in the patch the following:

- Add a .patch file to the media/liboggz directory containing this change so it won't be lost when we next update liboggz 
- Add a line to update.sh to apply the patch.
- Add to README_MOZILLA a line describing the patch file and what bug it is for.

See the other patches in media/liboggz for details.

Comment 10

[Shailen]

Attachment: Changes to README_MOZILLA and update.sh

Comment 11

[Shailen]

Attachment: .patch file

Comment 12

[Marco Bonardo [:mak]]

i think you want to attach a diff that adds the .patch file to the suggested folder, not the patch itself, if someone pushes this like it is he will change the file instead.

Comment 13

[Dão Gottwald [:dao]]

(In reply to comment #12)
> i think you want to attach a diff that adds the .patch file to the suggested
> folder

Right, please do so.

Comment 14

[Chris Pearce [:cpearce (Not reading bugmail)]]

We have removed liboggz from Firefox trunk, can we close this bug? Is this only applicable to 1.9.2?

Comment 15

[Uli Link (:ul-mcamafia)]

1.9.1 and 1.9.2 are still affected.

Comment 16

[Matthew Gregan [:kinetik]]

No action on this bug for a year, bug doesn't exist on trunk, closing.  If someone has the time/energy to shepherd this onto the necessary branches, feel free to reopen and assign the bug to yourself.

Comment 17

[Uli Link (:ul-mcamafia)]

Was fixed by a combined patch of bug# 576883 for branches 1.9.1 and 1.9.2.