576883 - AIX compilation errors in media/liboggplay and media/liboggz

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Uli Link (:ul-mcamafia)]

Attachment: Patch for 1.9.1 branch, AIX port

Some subtle patches for successfully building on AIX

Comment 1

[Uli Link (:ul-mcamafia)]

Same patch applies cleanly to branch 1.9.2.
Branches 1.9.1 and 1.9.2 only.

Comment 2

[cajbir (:cajbir)]

Comment on attachment 455967 [details] [diff] [review]
Patch for 1.9.1 branch, AIX port

For both the liboggplay and liboggz changes we'll need a .patch file with these changes, include it in the relevant media subdirectory, add a line to update.sh to apply it and update README_MOZILLA to note the patch file and this bug. There should be other patches in these directories to see how this works.

Are the dirac.c changes needed? As far as I can recall we don't use or build dirac support.

Comment 3

[Uli Link (:ul-mcamafia)]

Attachment: Adds support for AIX on stable branches

Reworked according to comment #2
recreated as upstream patches, included in update.sh and README_MOZILLA + in applied state.

Comment 4

[Uli Link (:ul-mcamafia)]

The dirac.c patch is needed on AIX and removes some CR/LF line endings.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 457514 [details] [diff] [review]
Adds support for AIX on stable branches

Approved for 1.9.2.9 and 1.9.1.12, a=dveditz for release-drivers

Comment 6

[Uli Link (:ul-mcamafia)]

Hmmm, there is a little conflict with the fixes of Bug 533822
in branch 1.9.2 update.sh and README_MOZILLA files. So I will adjust/recreate
the patch for branch 1.9.2. The patched sources itself have cleanly applied.

Comment 7

[Uli Link (:ul-mcamafia)]

Attachment: patch adjusted/manually merged for branch 1.9.2

The applied source patches have applied cleanly, only recreated the NPOTB in both update.sh and README_MOZILLA files, as there was a change within the context.
The original patch still applied cleanly on a freshly pulled branch 1.9.1.

Comment 8

[Daniel Veditz [:dveditz]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/2a5cdb29af2a
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/49ed52dfa7a9

It's not clear to me if this change is needed on the trunk so I'll leave it open. If it's for the trunk it'll need explicit approval there, too, now.

Comment 9

[Matthew Gregan [:kinetik]]

oggz and oggplay aren't on trunk, so this bug is branch only.

Comment 10

[Uli Link (:ul-mcamafia)]

The NPOTB added files

media/liboggplay/oggplay-aix.patch
media/liboggz/oggz-aix.patch

have missed adding/landing.

Comment 11

[Uli Link (:ul-mcamafia)]

Attachment: Followup patch adding the NPOTB upstream patch files

Only the upstream patch files should be added, or the update.sh script wom't find it's patch. Carrying forward r+

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 472162 [details] [diff] [review]
Followup patch adding the NPOTB upstream patch files

Approved for 1.9.2.11 and 1.9.1.14, a=dveditz

Sorry I forgot these.

Comment 13

[Daniel Veditz [:dveditz]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1c08c7f691b2
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/c5bd841d7226

Although it's going to screw up our queries, I'm not going to update the status1.9.x fields. Seems more appropriate for them to reflect when the compilation errors were fixed.